bitmap_empty() is better than bitmap_weight() because it may return earlier, and improves on readability.
Unified · Split
| @@ -206,11 +206,10 @@ void __init riscv_fill_hwcap(void) · 205 unmodified lines | ||
| 206 | 206 | else |
| 207 | 207 | elf_hwcap = this_hwcap; |
| 208 | 208 | |
| 209 | − if (bitmap_weight(riscv_isa, RISCV_ISA_EXT_MAX)) | |
| 210 | − bitmap_and(riscv_isa, riscv_isa, this_isa, RISCV_ISA_EXT_MAX); | |
| 211 | − else | |
| 209 | + if (bitmap_empty(riscv_isa, RISCV_ISA_EXT_MAX)) | |
| 212 | 210 | bitmap_copy(riscv_isa, this_isa, RISCV_ISA_EXT_MAX); |
| 213 | − | |
| 211 | + else | |
| 212 | + bitmap_and(riscv_isa, riscv_isa, this_isa, RISCV_ISA_EXT_MAX); | |
| 214 | 213 | } |
| 215 | 214 | |
| 216 | 215 | /* We don't support systems with F but without D, so mask those out |