History

checkpatch: Add warnings for {smp_,}read_barrier_depends()

Now that both smp_read_barrier_depends() and read_barrier_depends() are being de-emphasized, warn if any are added.

Paul E. McKenney committed 8 years ago

Commit 91db2591 parent dfe1b441 file · +6 −0Browse files

Showing the changes to scripts/checkpatch.pl (1 of 1 file). Show all

Unified · Split

scripts/checkpatch.pl+6−0
@@ -5586,6 +5586,12 @@ sub process { · 5585 unmodified lines
55865586 }
55875587 }
55885588
5589+# check for smp_read_barrier_depends and read_barrier_depends
5590+ if (!$file && $line =~ /\b(smp_|)read_barrier_depends\s*\(/) {
5591+ WARN("READ_BARRIER_DEPENDS",
5592+ "$1read_barrier_depends should only be used in READ_ONCE or DEC Alpha code\n" . $herecurr);
5593+ }
5594+
55895595 # check of hardware specific defines
55905596 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
55915597 CHK("ARCH_DEFINES",

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t