History

netpoll: use netpoll_rx_on() in netpoll_rx()

The logic of the code is same, just call netpoll_rx_on().

Amerigo Wang committed 14 years ago

Commit 91fe4a41 parent 57c5d461 file · +9 −9Browse files

Showing the changes to include/linux (1 of 1 file). Show all

Unified · Split

include/linux/netpoll.h+9−9
@@ -63,6 +63,13 @@ static inline void netpoll_send_skb(struct netpoll *np, struct sk_buff *skb) · 62 unmodified lines
6363
6464
6565 #ifdef CONFIG_NETPOLL
66+static inline int netpoll_rx_on(struct sk_buff *skb)
67+{
68+ struct netpoll_info *npinfo = rcu_dereference_bh(skb->dev->npinfo);
69+
70+ return npinfo && (!list_empty(&npinfo->rx_np) || npinfo->rx_flags);
71+}
72+
6673 static inline bool netpoll_rx(struct sk_buff *skb)
6774 {
6875 struct netpoll_info *npinfo;
@@ -70,11 +77,11 @@ static inline bool netpoll_rx(struct sk_buff *skb) · 1 unmodified line
7077 bool ret = false;
7178
7279 local_irq_save(flags);
73− npinfo = rcu_dereference_bh(skb->dev->npinfo);
7480
75− if (!npinfo || (list_empty(&npinfo->rx_np) && !npinfo->rx_flags))
81+ if (!netpoll_rx_on(skb))
7682 goto out;
7783
84+ npinfo = rcu_dereference_bh(skb->dev->npinfo);
7885 spin_lock(&npinfo->rx_lock);
7986 /* check rx_flags again with the lock held */
8087 if (npinfo->rx_flags && __netpoll_rx(skb, npinfo))
@@ -86,13 +93,6 @@ out: · 5 unmodified lines
8693 return ret;
8794 }
8895
89−static inline int netpoll_rx_on(struct sk_buff *skb)
90−{
91− struct netpoll_info *npinfo = rcu_dereference_bh(skb->dev->npinfo);
92−
93− return npinfo && (!list_empty(&npinfo->rx_np) || npinfo->rx_flags);
94−}
95−
9696 static inline int netpoll_receive_skb(struct sk_buff *skb)
9797 {
9898 if (!list_empty(&skb->dev->napi_list))