History

kbuild: support W=c and W=e shorthands for Kconfig

KCONFIG_WARN_UNKNOWN_SYMBOLS=1 and KCONFIG_WERROR=1 are descriptive and suitable in scripting, but typing them from the command line can be tedious. Associate them with KBUILD_EXTRA_WARN (and the W= shorthand). Support a new letter 'c' to enable extra checks in Kconfig. You can still manage compiler warnings (W=1) and Kconfig warnings (W=c) independently. Reuse the letter 'e' to turn Kconfig warnings into errors. As usual, you can combine multiple letters in KCONFIG_EXTRA_WARN. $ KCONFIG_WARN_UNKNOWN_SYMBOLS=1 KCONFIG_WERROR=1 make defconfig can be shortened to: $ KBUILD_EXTRA_WARN=ce make defconfig or, even shorter: $ make W=ce defconfig

Masahiro Yamada committed 2 years ago

Commit 92ef4321 parent ef6609a3 files · +18 −9Browse files

Showing the changes to scripts (2 of 3 files). Show all

Unified · Split

2 files
  1. scripts/Makefile.extrawarn +0 −9
  2. scripts/kconfig/Makefile +8 −0
scripts/Makefile.extrawarn+0−9
@@ -80,15 +80,6 @@ KBUILD_CFLAGS += $(call cc-option,-Werror=designated-init) · 79 unmodified lines
80# Warn if there is an enum types mismatch80# Warn if there is an enum types mismatch
81KBUILD_CFLAGS += $(call cc-option,-Wenum-conversion)81KBUILD_CFLAGS += $(call cc-option,-Wenum-conversion)
82 82
83# backward compatibility
84KBUILD_EXTRA_WARN ?= $(KBUILD_ENABLE_EXTRA_GCC_CHECKS)
85
86ifeq ("$(origin W)", "command line")
87 KBUILD_EXTRA_WARN := $(W)
88endif
89
90export KBUILD_EXTRA_WARN
91
92#83#
93# W=1 - warnings which may be relevant and do not occur too often84# W=1 - warnings which may be relevant and do not occur too often
94#85#
scripts/kconfig/Makefile+8−0
@@ -27,6 +27,14 @@ KCONFIG_DEFCONFIG_LIST += \ · 26 unmodified lines
27endif27endif
28KCONFIG_DEFCONFIG_LIST += arch/$(SRCARCH)/configs/$(KBUILD_DEFCONFIG)28KCONFIG_DEFCONFIG_LIST += arch/$(SRCARCH)/configs/$(KBUILD_DEFCONFIG)
29 29
30ifneq ($(findstring c, $(KBUILD_EXTRA_WARN)),)
31export KCONFIG_WARN_UNKNOWN_SYMBOLS=1
32endif
33
34ifneq ($(findstring e, $(KBUILD_EXTRA_WARN)),)
35export KCONFIG_WERROR=1
36endif
37
30# We need this, in case the user has it in its environment38# We need this, in case the user has it in its environment
31unexport CONFIG_39unexport CONFIG_
32 40

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t