History

xattr: Constify ->name member of "struct xattr".

Since everybody sets kstrdup()ed constant string to "struct xattr"->name but nobody modifies "struct xattr"->name , we can omit kstrdup() and its failure checking by constifying ->name member of "struct xattr".

Tetsuo Handa committed 13 years ago

Commit 95489061 parent be0306b9 files · +21 −31Browse files

Showing the changes to include/linux (2 of 9 files). Show all

Unified · Split

2 files
  1. include/linux/security.h +4 −4
  2. include/linux/xattr.h +1 −1
include/linux/security.h+4−4
@@ -1492,7 +1492,7 @@ struct security_operations { · 1491 unmodified lines
1492 int (*inode_alloc_security) (struct inode *inode);1492 int (*inode_alloc_security) (struct inode *inode);
1493 void (*inode_free_security) (struct inode *inode);1493 void (*inode_free_security) (struct inode *inode);
1494 int (*inode_init_security) (struct inode *inode, struct inode *dir,1494 int (*inode_init_security) (struct inode *inode, struct inode *dir,
1495 const struct qstr *qstr, char **name,1495 const struct qstr *qstr, const char **name,
1496 void **value, size_t *len);1496 void **value, size_t *len);
1497 int (*inode_create) (struct inode *dir,1497 int (*inode_create) (struct inode *dir,
1498 struct dentry *dentry, umode_t mode);1498 struct dentry *dentry, umode_t mode);
@@ -1770,7 +1770,7 @@ int security_inode_init_security(struct inode *inode, struct inode *dir, · 271 unmodified lines
1770 const struct qstr *qstr,1770 const struct qstr *qstr,
1771 initxattrs initxattrs, void *fs_data);1771 initxattrs initxattrs, void *fs_data);
1772int security_old_inode_init_security(struct inode *inode, struct inode *dir,1772int security_old_inode_init_security(struct inode *inode, struct inode *dir,
1773 const struct qstr *qstr, char **name,1773 const struct qstr *qstr, const char **name,
1774 void **value, size_t *len);1774 void **value, size_t *len);
1775int security_inode_create(struct inode *dir, struct dentry *dentry, umode_t mode);1775int security_inode_create(struct inode *dir, struct dentry *dentry, umode_t mode);
1776int security_inode_link(struct dentry *old_dentry, struct inode *dir,1776int security_inode_link(struct dentry *old_dentry, struct inode *dir,
@@ -2094,8 +2094,8 @@ static inline int security_inode_init_security(struct inode *inode, · 317 unmodified lines
2094static inline int security_old_inode_init_security(struct inode *inode,2094static inline int security_old_inode_init_security(struct inode *inode,
2095 struct inode *dir,2095 struct inode *dir,
2096 const struct qstr *qstr,2096 const struct qstr *qstr,
2097 char **name, void **value,2097 const char **name,
2098 size_t *len)2098 void **value, size_t *len)
2099{2099{
2100 return -EOPNOTSUPP;2100 return -EOPNOTSUPP;
2101}2101}
include/linux/xattr.h+1−1
@@ -31,7 +31,7 @@ struct xattr_handler { · 30 unmodified lines
31};31};
32 32
33struct xattr {33struct xattr {
34 char *name;34 const char *name;
35 void *value;35 void *value;
36 size_t value_len;36 size_t value_len;
37};37};

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t