History

xattr: Constify ->name member of "struct xattr".

Since everybody sets kstrdup()ed constant string to "struct xattr"->name but nobody modifies "struct xattr"->name , we can omit kstrdup() and its failure checking by constifying ->name member of "struct xattr".

Tetsuo Handa committed 13 years ago

Commit 95489061 parent be0306b9 files · +21 −31Browse files

Showing the changes to include/linux (2 of 9 files). Show all

Unified · Split

2 files
  1. include/linux/security.h +4 −4
  2. include/linux/xattr.h +1 −1
include/linux/security.h+4−4
@@ -1492,7 +1492,7 @@ struct security_operations { · 1491 unmodified lines
14921492 int (*inode_alloc_security) (struct inode *inode);
14931493 void (*inode_free_security) (struct inode *inode);
14941494 int (*inode_init_security) (struct inode *inode, struct inode *dir,
1495− const struct qstr *qstr, char **name,
1495+ const struct qstr *qstr, const char **name,
14961496 void **value, size_t *len);
14971497 int (*inode_create) (struct inode *dir,
14981498 struct dentry *dentry, umode_t mode);
@@ -1770,7 +1770,7 @@ int security_inode_init_security(struct inode *inode, struct inode *dir, · 271 unmodified lines
17701770 const struct qstr *qstr,
17711771 initxattrs initxattrs, void *fs_data);
17721772 int security_old_inode_init_security(struct inode *inode, struct inode *dir,
1773− const struct qstr *qstr, char **name,
1773+ const struct qstr *qstr, const char **name,
17741774 void **value, size_t *len);
17751775 int security_inode_create(struct inode *dir, struct dentry *dentry, umode_t mode);
17761776 int security_inode_link(struct dentry *old_dentry, struct inode *dir,
@@ -2094,8 +2094,8 @@ static inline int security_inode_init_security(struct inode *inode, · 317 unmodified lines
20942094 static inline int security_old_inode_init_security(struct inode *inode,
20952095 struct inode *dir,
20962096 const struct qstr *qstr,
2097− char **name, void **value,
2098− size_t *len)
2097+ const char **name,
2098+ void **value, size_t *len)
20992099 {
21002100 return -EOPNOTSUPP;
21012101 }
include/linux/xattr.h+1−1
@@ -31,7 +31,7 @@ struct xattr_handler { · 30 unmodified lines
3131 };
3232
3333 struct xattr {
34− char *name;
34+ const char *name;
3535 void *value;
3636 size_t value_len;
3737 };

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t