History

bpf: introduce BPF_F_LOCK flag

Introduce BPF_F_LOCK flag for map_lookup and map_update syscall commands and for map_update() helper function. In all these cases take a lock of existing element (which was provided in BTF description) before copying (in or out) the rest of map value. Implementation details that are part of uapi: Array: The array map takes the element lock for lookup/update. Hash: hash map also takes the lock for lookup/update and tries to avoid the bucket lock. If old element exists it takes the element lock and updates the element in place. If element doesn't exist it allocates new one and inserts into hash table while holding the bucket lock. In rare case the hashmap has to take both the bucket lock and the element lock to update old value in place. Cgroup local storage: It is similar to array. update in place and lookup are done with lock taken.

Alexei Starovoitov committed 7 years ago

Commit 96049f31 parent ab963be7 files · +110 −14Browse files

Showing the changes to include/linux (1 of 7 files). Show all

Unified · Split

include/linux/bpf.h+2−0
@@ -119,6 +119,8 @@ static inline void copy_map_value(struct bpf_map *map, void *dst, void *src) · 118 unmodified lines
119 memcpy(dst, src, map->value_size);119 memcpy(dst, src, map->value_size);
120 }120 }
121}121}
122void copy_map_value_locked(struct bpf_map *map, void *dst, void *src,
123 bool lock_src);
122 124
123struct bpf_offload_dev;125struct bpf_offload_dev;
124struct bpf_offloaded_map;126struct bpf_offloaded_map;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t