History

char: mxser, fix ISA board lookup

There's a bug in the mxser kernel module that still appears in the 2.6.29.4 kernel. mxser_get_ISA_conf takes a ioaddress as its first argument, by passing the not of the ioaddr, you're effectively passing 0 which means it won't be able to talk to an ISA card. I have tested this, and removing the ! fixes the problem.

Peter Botha committed 17 years ago

Commit 96050df1 parent a61d90d1 file · +1 −1Browse files

Unified · Split

drivers/char/mxser.c+1−1
@@ -2711,7 +2711,7 @@ static int __init mxser_module_init(void) · 2710 unmodified lines
2711 continue;2711 continue;
2712 2712
2713 brd = &mxser_boards[m];2713 brd = &mxser_boards[m];
2714 retval = mxser_get_ISA_conf(!ioaddr[b], brd);2714 retval = mxser_get_ISA_conf(ioaddr[b], brd);
2715 if (retval <= 0) {2715 if (retval <= 0) {
2716 brd->info = NULL;2716 brd->info = NULL;
2717 continue;2717 continue;