void function lines that use a single tab then "return;" are generally unnecessary.
Showing the changes to scripts/checkpatch.pl (1 of 1 file). Show all
Unified · Split
| @@ -3470,6 +3470,13 @@ sub process { · 3469 unmodified lines | ||
| 3470 | 3470 | } |
| 3471 | 3471 | } |
| 3472 | 3472 | |
| 3473 | +# unnecessary return in a void function? (a single leading tab, then return;) | |
| 3474 | + if ($sline =~ /^\+\treturn\s*;\s*$/ && | |
| 3475 | + $prevline =~ /^\+/) { | |
| 3476 | + WARN("RETURN_VOID", | |
| 3477 | + "void function return statements are not generally useful\n" . $herecurr); | |
| 3478 | + } | |
| 3479 | + | |
| 3473 | 3480 | # if statements using unnecessary parentheses - ie: if ((foo == bar)) |
| 3474 | 3481 | if ($^V && $^V ge 5.10.0 && |
| 3475 | 3482 | $line =~ /\bif\s*((?:\(\s*){2,})/) { |