Let genphy_c45_read_link manage the devices to check, this removes overhead from callers. Add C22EXT to the list of excluded devices because it doesn't implement the status register. According to the 802.3 clause 45 spec registers 29.0 - 29.4 are reserved. At the moment we have very few clause 45 PHY drivers, so we are lacking experience whether other drivers will have to exclude further devices, or may need to check PHY XS. If we should figure out that list of devices to check needs to be configurable, I think best will be to add a device list member to struct phy_driver. v2: - adjusted commit message - exclude also device C22EXT from link checking
Showing the changes to include/linux (1 of 4 files). Show all
Unified · Split
| @@ -1094,7 +1094,7 @@ int genphy_write_mmd_unsupported(struct phy_device *phdev, int devnum, · 1093 unmodified lines | ||
| 1094 | 1094 | /* Clause 45 PHY */ |
| 1095 | 1095 | int genphy_c45_restart_aneg(struct phy_device *phydev); |
| 1096 | 1096 | int genphy_c45_aneg_done(struct phy_device *phydev); |
| 1097 | −int genphy_c45_read_link(struct phy_device *phydev, u32 mmd_mask); | |
| 1097 | +int genphy_c45_read_link(struct phy_device *phydev); | |
| 1098 | 1098 | int genphy_c45_read_lpa(struct phy_device *phydev); |
| 1099 | 1099 | int genphy_c45_read_pma(struct phy_device *phydev); |
| 1100 | 1100 | int genphy_c45_pma_setup_forced(struct phy_device *phydev); |