According to commit message in the original commit c75b1d9421f8 ("fs: add fcntl() interface for setting/getting write life time hints"), as well as userspace library[1] and man page update[2], R/W hint constants are intended to have RWH_* prefix. However, RWF_WRITE_LIFE_NOT_SET retained "RWF_*" prefix used in the early versions of the proposed patch set[3]. Rename it and provide the old name as a synonym for the new one for backward compatibility. [1] https://github.com/axboe/fio/commit/bd553af6c849 [2] https://github.com/mkerrisk/man-pages/commit/580082a186fd [3] https://www.mail-archive.com/linux-block@vger.kernel.org/msg09638.html
Showing the changes to include/uapi/linux (1 of 3 files). Show all
Unified · Split
| @@ -58,13 +58,20 @@ · 57 unmodified lines | |||
| 58 | * Valid hint values for F_{GET,SET}_RW_HINT. 0 is "not set", or can be | 58 | * Valid hint values for F_{GET,SET}_RW_HINT. 0 is "not set", or can be |
| 59 | * used to clear any hints previously set. | 59 | * used to clear any hints previously set. |
| 60 | */ | 60 | */ |
| 61 | #define RWF_WRITE_LIFE_NOT_SET 0 | 61 | #define RWH_WRITE_LIFE_NOT_SET 0 |
| 62 | #define RWH_WRITE_LIFE_NONE 1 | 62 | #define RWH_WRITE_LIFE_NONE 1 |
| 63 | #define RWH_WRITE_LIFE_SHORT 2 | 63 | #define RWH_WRITE_LIFE_SHORT 2 |
| 64 | #define RWH_WRITE_LIFE_MEDIUM 3 | 64 | #define RWH_WRITE_LIFE_MEDIUM 3 |
| 65 | #define RWH_WRITE_LIFE_LONG 4 | 65 | #define RWH_WRITE_LIFE_LONG 4 |
| 66 | #define RWH_WRITE_LIFE_EXTREME 5 | 66 | #define RWH_WRITE_LIFE_EXTREME 5 |
| 67 | 67 | ||
| 68 | /* | ||
| 69 | * The originally introduced spelling is remained from the first | ||
| 70 | * versions of the patch set that introduced the feature, see commit | ||
| 71 | * v4.13-rc1~212^2~51. | ||
| 72 | */ | ||
| 73 | #define RWF_WRITE_LIFE_NOT_SET RWH_WRITE_LIFE_NOT_SET | ||
| 74 | |||
| 68 | /* | 75 | /* |
| 69 | * Types of directory notifications that may be requested. | 76 | * Types of directory notifications that may be requested. |
| 70 | */ | 77 | */ |