History

kbuild: use proper prefix for tarballs to fix rpm-pkg build error

Since commit f8d94c4e403c ("kbuild: do not create intermediate *.tar for source tarballs"), 'make rpm-pkg' fails because the prefix of the source tarball is 'linux.tar/' instead of 'linux/'. $(basename $@) strips only '.gz' from the filename linux.tar.gz. You need to strip two suffixes from compressed tarballs and one suffix from uncompressed tarballs (for example 'perf-6.3.0.tar' generated by 'make perf-tar-src-pkg'). One tricky fix might be --prefix=$(firstword $(subst .tar, ,$@))/ but I think it is better to hard-code the prefix.

Masahiro Yamada committed 3 years ago

Commit 9cedc5e1 parent 8b824221 file · +3 −3Browse files

Showing the changes to scripts (1 of 1 file). Show all

Unified · Split

scripts/Makefile.package+3−3
@@ -49,7 +49,7 @@ git-config-tar.zst = -c tar.tar.zst.command="$(ZSTD)" · 48 unmodified lines
4949
5050 quiet_cmd_archive = ARCHIVE $@
5151 cmd_archive = git -C $(srctree) $(git-config-tar$(suffix $@)) archive \
52− --output=$$(realpath $@) --prefix=$(basename $@)/ $(archive-args)
52+ --output=$$(realpath $@) $(archive-args)
5353
5454 # Linux source tarball
5555 # ---------------------------------------------------------------------------
@@ -57,7 +57,7 @@ quiet_cmd_archive = ARCHIVE $@ · 1 unmodified line
5757 linux-tarballs := $(addprefix linux, .tar.gz)
5858
5959 targets += $(linux-tarballs)
60−$(linux-tarballs): archive-args = $$(cat $<)
60+$(linux-tarballs): archive-args = --prefix=linux/ $$(cat $<)
6161 $(linux-tarballs): .tmp_HEAD FORCE
6262 $(call if_changed,archive)
6363
@@ -189,7 +189,7 @@ perf-archive-args = --add-file=$$(realpath $(word 2, $^)) \ · 125 unmodified lines
189189 perf-tarballs := $(addprefix perf-$(KERNELVERSION), .tar .tar.gz .tar.bz2 .tar.xz .tar.zst)
190190
191191 targets += $(perf-tarballs)
192−$(perf-tarballs): archive-args = $(perf-archive-args)
192+$(perf-tarballs): archive-args = --prefix=perf-$(KERNELVERSION)/ $(perf-archive-args)
193193 $(perf-tarballs): tools/perf/MANIFEST .tmp_perf/HEAD .tmp_perf/PERF-VERSION-FILE FORCE
194194 $(call if_changed,archive)
195195