History

pinctrl: delete raw device pointers in pinmux maps

After discussion with Mark Brown in an unrelated thread about ADC lookups, it came to my knowledge that the ability to pass a struct device * in the regulator consumers is just a historical artifact, and not really recommended. Since there are no in-kernel users of these pointers, we just kill them right now, before someone starts to use them.

Linus Walleij committed 14 years ago

Commit 9dfac4f1 parent 8dc6ae46 files · +23 −54Browse files

Showing the changes to include/linux/pinctrl (1 of 6 files). Show all

Unified · Split

include/linux/pinctrl/machine.h+2−10
@@ -17,22 +17,16 @@ · 16 unmodified lines
1717 * @name: the name of this specific map entry for the particular machine.
1818 * This is the second parameter passed to pinmux_get() when you want
1919 * to have several mappings to the same device
20− * @ctrl_dev: the pin control device to be used by this mapping, may be NULL
21− * if you provide .ctrl_dev_name instead (this is more common)
2220 * @ctrl_dev_name: the name of the device controlling this specific mapping,
23− * the name must be the same as in your struct device*, may be NULL if
24− * you provide .ctrl_dev instead
21+ * the name must be the same as in your struct device*
2522 * @function: a function in the driver to use for this mapping, the driver
2623 * will lookup the function referenced by this ID on the specified
2724 * pin control device
2825 * @group: sometimes a function can map to different pin groups, so this
2926 * selects a certain specific pin group to activate for the function, if
3027 * left as NULL, the first applicable group will be used
31− * @dev: the device using this specific mapping, may be NULL if you provide
32− * .dev_name instead (this is more common)
3328 * @dev_name: the name of the device using this specific mapping, the name
34− * must be the same as in your struct device*, may be NULL if you
35− * provide .dev instead
29+ * must be the same as in your struct device*
3630 * @hog_on_boot: if this is set to true, the pin control subsystem will itself
3731 * hog the mappings as the pinmux device drivers are attached, so this is
3832 * typically used with system maps (mux mappings without an assigned
@@ -42,11 +36,9 @@ · 3 unmodified lines
4236 */
4337 struct pinmux_map {
4438 const char *name;
45− struct device *ctrl_dev;
4639 const char *ctrl_dev_name;
4740 const char *function;
4841 const char *group;
49− struct device *dev;
5042 const char *dev_name;
5143 bool hog_on_boot;
5244 };

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t