History

autofs: sanity check status reported with AUTOFS_DEV_IOCTL_FAIL

If a positive status is passed with the AUTOFS_DEV_IOCTL_FAIL ioctl, autofs4_d_automount() will return ERR_PTR(status) with that status to follow_automount(), which will then dereference an invalid pointer. So treat a positive status the same as zero, and map to ENOENT. See comment in systemd src/core/automount.c::automount_send_ready().

NeilBrown committed 9 years ago

Commit 9fa4eb81 parent 029c54b1 file · +1 −1Browse files

Unified · Split

fs/autofs4/dev-ioctl.c+1−1
@@ -344,7 +344,7 @@ static int autofs_dev_ioctl_fail(struct file *fp, · 343 unmodified lines
344344 int status;
345345
346346 token = (autofs_wqt_t) param->fail.token;
347− status = param->fail.status ? param->fail.status : -ENOENT;
347+ status = param->fail.status < 0 ? param->fail.status : -ENOENT;
348348 return autofs4_wait_release(sbi, token, status);
349349 }
350350

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t