History

genetlink: no longer support using static family IDs

Static family IDs have never really been used, the only use case was the workaround I introduced for those users that assumed their family ID was also their multicast group ID. Additionally, because static family IDs would never be reserved by the generic netlink code, using a relatively low ID would only work for built-in families that can be registered immediately after generic netlink is started, which is basically only the control family (apart from the workaround code, which I also had to add code for so it would reserve those IDs) Thus, anything other than GENL_ID_GENERATE is flawed and luckily not used except in the cases I mentioned. Move those workarounds into a few lines of code, and then get rid of GENL_ID_GENERATE entirely, making it more robust.

Johannes Berg committed 10 years ago

Commit a07ea4d1 parent c90c39d37 files · +24 −69Browse files

Showing the changes to include/uapi/linux (1 of 37 files). Show all

Unified · Split

include/uapi/linux/genetlink.h+0−1
@@ -26,7 +26,6 @@ struct genlmsghdr { · 25 unmodified lines
2626 /*
2727 * List of reserved static generic netlink identifiers:
2828 */
29−#define GENL_ID_GENERATE 0
3029 #define GENL_ID_CTRL NLMSG_MIN_TYPE
3130 #define GENL_ID_VFS_DQUOT (NLMSG_MIN_TYPE + 1)
3231 #define GENL_ID_PMCRAID (NLMSG_MIN_TYPE + 2)

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t