History

checkpatch: fix ignoring cover-letter logic

Currently running checkpatch on a directory with a cover-letter.patch file reports the following error: ----------------------------------------- patches/smp-v2/v2-0000-cover-letter.patch ----------------------------------------- ERROR: Does not appear to be a unified-diff format patch The logic to suppress the unified-diff check for cover letters is there but is checking $file instead of $filename. Fix the variable to use the correct one.

Stafford Horne committed 9 years ago

Commit a08ffbe1 parent d22e3d61 file · +1 −1Browse files

Showing the changes to scripts/checkpatch.pl (1 of 1 file). Show all

Unified · Split

scripts/checkpatch.pl+1−1
@@ -6390,7 +6390,7 @@ sub process { · 6389 unmodified lines
63906390 exit(0);
63916391 }
63926392
6393− if (!$is_patch && $file !~ /cover-letter\.patch$/) {
6393+ if (!$is_patch && $filename !~ /cover-letter\.patch$/) {
63946394 ERROR("NOT_UNIFIED_DIFF",
63956395 "Does not appear to be a unified-diff format patch\n");
63966396 }