History

drm: Fix docbook warnings in hdr metadata helper structures

Fixes the following warnings: ./include/drm/drm_mode_config.h:841: warning: Incorrect use of kernel-doc format: * hdr_output_metadata_property: Connector property containing hdr ./include/drm/drm_mode_config.h:918: warning: Function parameter or member 'hdr_output_metadata_property' not described in 'drm_mode_config' ./include/drm/drm_connector.h:1251: warning: Function parameter or member 'hdr_output_metadata' not described in 'drm_connector' ./include/drm/drm_connector.h:1251: warning: Function parameter or member 'hdr_sink_metadata' not described in 'drm_connector' Also adds some property documentation for HDR Metadata Connector Property in connector property create function. v2: Fixed Sean Paul's review comments. v3: Fixed Daniel Vetter's review comments, added the UAPI structure definition section in kernel docs. v4: Fixed Daniel Vetter's review comments. v5: Added structure member references as per Daniel's suggestion.

Uma Shankar committed 7 years ago

Commit a09db881 parent 309aa925 files · +128 −3Browse files

Showing the changes to include/uapi (1 of 5 files). Show all

Unified · Split

include/uapi/drm/drm_mode.h+73−1
@@ -33,6 +33,15 @@ · 32 unmodified lines
33extern "C" {33extern "C" {
34#endif34#endif
35 35
36/**
37 * DOC: overview
38 *
39 * DRM exposes many UAPI and structure definition to have a consistent
40 * and standardized interface with user.
41 * Userspace can refer to these structure definitions and UAPI formats
42 * to communicate to driver
43 */
44
36#define DRM_CONNECTOR_NAME_LEN 3245#define DRM_CONNECTOR_NAME_LEN 32
37#define DRM_DISPLAY_MODE_LEN 3246#define DRM_DISPLAY_MODE_LEN 32
38#define DRM_PROP_NAME_LEN 3247#define DRM_PROP_NAME_LEN 32
@@ -630,24 +639,87 @@ struct drm_color_lut { · 591 unmodified lines
630 __u16 reserved;639 __u16 reserved;
631};640};
632 641
633/* HDR Metadata Infoframe as per 861.G spec */642/**
643 * struct hdr_metadata_infoframe - HDR Metadata Infoframe Data.
644 *
645 * HDR Metadata Infoframe as per CTA 861.G spec. This is expected
646 * to match exactly with the spec.
647 *
648 * Userspace is expected to pass the metadata information as per
649 * the format described in this structure.
650 */
634struct hdr_metadata_infoframe {651struct hdr_metadata_infoframe {
652 /**
653 * @eotf: Electro-Optical Transfer Function (EOTF)
654 * used in the stream.
655 */
635 __u8 eotf;656 __u8 eotf;
657 /**
658 * @metadata_type: Static_Metadata_Descriptor_ID.
659 */
636 __u8 metadata_type;660 __u8 metadata_type;
661 /**
662 * @display_primaries: Color Primaries of the Data.
663 * These are coded as unsigned 16-bit values in units of
664 * 0.00002, where 0x0000 represents zero and 0xC350
665 * represents 1.0000.
666 * @display_primaries.x: X cordinate of color primary.
667 * @display_primaries.y: Y cordinate of color primary.
668 */
637 struct {669 struct {
638 __u16 x, y;670 __u16 x, y;
639 } display_primaries[3];671 } display_primaries[3];
672 /**
673 * @white_point: White Point of Colorspace Data.
674 * These are coded as unsigned 16-bit values in units of
675 * 0.00002, where 0x0000 represents zero and 0xC350
676 * represents 1.0000.
677 * @white_point.x: X cordinate of whitepoint of color primary.
678 * @white_point.y: Y cordinate of whitepoint of color primary.
679 */
640 struct {680 struct {
641 __u16 x, y;681 __u16 x, y;
642 } white_point;682 } white_point;
683 /**
684 * @max_display_mastering_luminance: Max Mastering Display Luminance.
685 * This value is coded as an unsigned 16-bit value in units of 1 cd/m2,
686 * where 0x0001 represents 1 cd/m2 and 0xFFFF represents 65535 cd/m2.
687 */
643 __u16 max_display_mastering_luminance;688 __u16 max_display_mastering_luminance;
689 /**
690 * @min_display_mastering_luminance: Min Mastering Display Luminance.
691 * This value is coded as an unsigned 16-bit value in units of
692 * 0.0001 cd/m2, where 0x0001 represents 0.0001 cd/m2 and 0xFFFF
693 * represents 6.5535 cd/m2.
694 */
644 __u16 min_display_mastering_luminance;695 __u16 min_display_mastering_luminance;
696 /**
697 * @max_cll: Max Content Light Level.
698 * This value is coded as an unsigned 16-bit value in units of 1 cd/m2,
699 * where 0x0001 represents 1 cd/m2 and 0xFFFF represents 65535 cd/m2.
700 */
645 __u16 max_cll;701 __u16 max_cll;
702 /**
703 * @max_fall: Max Frame Average Light Level.
704 * This value is coded as an unsigned 16-bit value in units of 1 cd/m2,
705 * where 0x0001 represents 1 cd/m2 and 0xFFFF represents 65535 cd/m2.
706 */
646 __u16 max_fall;707 __u16 max_fall;
647};708};
648 709
710/**
711 * struct hdr_output_metadata - HDR output metadata
712 *
713 * Metadata Information to be passed from userspace
714 */
649struct hdr_output_metadata {715struct hdr_output_metadata {
716 /**
717 * @metadata_type: Static_Metadata_Descriptor_ID.
718 */
650 __u32 metadata_type;719 __u32 metadata_type;
720 /**
721 * @hdmi_metadata_type1: HDR Metadata Infoframe.
722 */
651 union {723 union {
652 struct hdr_metadata_infoframe hdmi_metadata_type1;724 struct hdr_metadata_infoframe hdmi_metadata_type1;
653 };725 };

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t