History

kgdb: gdb "monitor" -> kdb passthrough

One of the driving forces behind integrating another front end (kdb) to the debug core is to allow front end commands to be accessible via gdb's monitor command. It is true that you could write gdb macros to get certain data, but you may want to just use gdb to access the commands that are available in the kdb front end. This patch implements the Rcmd gdb stub packet. In gdb you access this with the "monitor" command. For instance you could type "monitor help", "monitor lsmod" or "monitor ps A" etc... There is no error checking or command restrictions on what you can and cannot access at this point. Doing something like trying to set breakpoints with the monitor command is going to cause nothing but problems. Perhaps in the future only the commands that are actually known to work with the gdb monitor command will be available.

Jason Wessel committed 16 years ago

Commit a0de0551 parent 6d45a1a5 files · +34 −6Browse files

Showing the changes to kernel/debug (5 of 5 files). Show all

Unified · Split

5 files
  1. kernel/debug/debug_core.c +1 −1
  2. kernel/debug/debug_core.h +2 −0
  3. kernel/debug/gdbstub.c +22 −0
  4. kernel/debug/kdb/kdb_io.c +9 −4
  5. kernel/debug/kdb/kdb_private.h +0 −1
kernel/debug/debug_core.c+1−1
@@ -82,7 +82,7 @@ static int kgdb_use_con; · 81 unmodified lines
82int dbg_switch_cpu;82int dbg_switch_cpu;
83 83
84/* Use kdb or gdbserver mode */84/* Use kdb or gdbserver mode */
85static int dbg_kdb_mode = 1;85int dbg_kdb_mode = 1;
86 86
87static int __init opt_kgdb_con(char *str)87static int __init opt_kgdb_con(char *str)
88{88{
kernel/debug/debug_core.h+2−0
@@ -66,9 +66,11 @@ extern void gdbstub_msg_write(const char *s, int len); · 65 unmodified lines
66 66
67/* gdbstub functions used for kdb <-> gdbstub transition */67/* gdbstub functions used for kdb <-> gdbstub transition */
68extern int gdbstub_state(struct kgdb_state *ks, char *cmd);68extern int gdbstub_state(struct kgdb_state *ks, char *cmd);
69extern int dbg_kdb_mode;
69 70
70#ifdef CONFIG_KGDB_KDB71#ifdef CONFIG_KGDB_KDB
71extern int kdb_stub(struct kgdb_state *ks);72extern int kdb_stub(struct kgdb_state *ks);
73extern int kdb_parse(const char *cmdstr);
72#else /* ! CONFIG_KGDB_KDB */74#else /* ! CONFIG_KGDB_KDB */
73static inline int kdb_stub(struct kgdb_state *ks)75static inline int kdb_stub(struct kgdb_state *ks)
74{76{
kernel/debug/gdbstub.c+22−0
@@ -201,6 +201,9 @@ void gdbstub_msg_write(const char *s, int len) · 200 unmodified lines
201 int wcount;201 int wcount;
202 int i;202 int i;
203 203
204 if (len == 0)
205 len = strlen(s);
206
204 /* 'O'utput */207 /* 'O'utput */
205 gdbmsgbuf[0] = 'O';208 gdbmsgbuf[0] = 'O';
206 209
@@ -685,6 +688,25 @@ static void gdb_cmd_query(struct kgdb_state *ks) · 478 unmodified lines
685 kgdb_mem2hex(tmpstr, remcom_out_buffer, strlen(tmpstr));688 kgdb_mem2hex(tmpstr, remcom_out_buffer, strlen(tmpstr));
686 }689 }
687 break;690 break;
691#ifdef CONFIG_KGDB_KDB
692 case 'R':
693 if (strncmp(remcom_in_buffer, "qRcmd,", 6) == 0) {
694 int len = strlen(remcom_in_buffer + 6);
695
696 if ((len % 2) != 0) {
697 strcpy(remcom_out_buffer, "E01");
698 break;
699 }
700 kgdb_hex2mem(remcom_in_buffer + 6,
701 remcom_out_buffer, len);
702 len = len / 2;
703 remcom_out_buffer[len++] = 0;
704
705 kdb_parse(remcom_out_buffer);
706 strcpy(remcom_out_buffer, "OK");
707 }
708 break;
709#endif
688 }710 }
689}711}
690 712
kernel/debug/kdb/kdb_io.c+9−4
@@ -21,6 +21,7 @@ · 20 unmodified lines
21#include <linux/smp.h>21#include <linux/smp.h>
22#include <linux/nmi.h>22#include <linux/nmi.h>
23#include <linux/delay.h>23#include <linux/delay.h>
24#include <linux/kgdb.h>
24#include <linux/kdb.h>25#include <linux/kdb.h>
25#include <linux/kallsyms.h>26#include <linux/kallsyms.h>
26#include "kdb_private.h"27#include "kdb_private.h"
@@ -669,10 +670,14 @@ kdb_printit: · 642 unmodified lines
669 * Write to all consoles.670 * Write to all consoles.
670 */671 */
671 retlen = strlen(kdb_buffer);672 retlen = strlen(kdb_buffer);
672 while (c) {673 if (!dbg_kdb_mode && kgdb_connected) {
673 c->write(c, kdb_buffer, retlen);674 gdbstub_msg_write(kdb_buffer, retlen);
674 touch_nmi_watchdog();675 } else {
675 c = c->next;676 while (c) {
677 c->write(c, kdb_buffer, retlen);
678 touch_nmi_watchdog();
679 c = c->next;
680 }
676 }681 }
677 if (logging) {682 if (logging) {
678 saved_loglevel = console_loglevel;683 saved_loglevel = console_loglevel;
kernel/debug/kdb/kdb_private.h+0−1
@@ -254,7 +254,6 @@ extern unsigned long kdb_task_state(const struct task_struct *p, · 253 unmodified lines
254 unsigned long mask);254 unsigned long mask);
255extern void kdb_ps_suppressed(void);255extern void kdb_ps_suppressed(void);
256extern void kdb_ps1(const struct task_struct *p);256extern void kdb_ps1(const struct task_struct *p);
257extern int kdb_parse(const char *cmdstr);
258extern void kdb_print_nameval(const char *name, unsigned long val);257extern void kdb_print_nameval(const char *name, unsigned long val);
259extern void kdb_send_sig_info(struct task_struct *p, struct siginfo *info);258extern void kdb_send_sig_info(struct task_struct *p, struct siginfo *info);
260extern void kdb_meminfo_proc_show(void);259extern void kdb_meminfo_proc_show(void);