History

SUNRPC: Fix transport accounting when caller specifies an rpc_xprt

Ensure that we do the required accounting for the round robin queue when the caller to rpc_init_task() has passed in a transport to be used.

Trond Myklebust committed 7 years ago

Commit a101b041 parent 347543e3 files · +24 −23Browse files

Unified · Split

3 files
  1. include/linux/sunrpc/clnt.h +2 −0
  2. net/sunrpc/clnt.c +20 −22
  3. net/sunrpc/sched.c +2 −1
include/linux/sunrpc/clnt.h+2−0
@@ -164,6 +164,8 @@ void rpc_shutdown_client(struct rpc_clnt *); · 163 unmodified lines
164164 void rpc_release_client(struct rpc_clnt *);
165165 void rpc_task_release_transport(struct rpc_task *);
166166 void rpc_task_release_client(struct rpc_task *);
167+struct rpc_xprt *rpc_task_get_xprt(struct rpc_clnt *clnt,
168+ struct rpc_xprt *xprt);
167169
168170 int rpcb_create_local(struct net *);
169171 void rpcb_put_local(struct net *);
net/sunrpc/clnt.c+20−22
@@ -978,11 +978,10 @@ out: · 977 unmodified lines
978978 }
979979 EXPORT_SYMBOL_GPL(rpc_bind_new_program);
980980
981−static struct rpc_xprt *
982−rpc_task_get_xprt(struct rpc_clnt *clnt)
981+struct rpc_xprt *
982+rpc_task_get_xprt(struct rpc_clnt *clnt, struct rpc_xprt *xprt)
983983 {
984984 struct rpc_xprt_switch *xps;
985− struct rpc_xprt *xprt= xprt_iter_get_next(&clnt->cl_xpi);
986985
987986 if (!xprt)
988987 return NULL;
@@ -995,24 +994,6 @@ rpc_task_get_xprt(struct rpc_clnt *clnt) · 6 unmodified lines
995994 return xprt;
996995 }
997996
998−static struct rpc_xprt *
999−rpc_task_get_first_xprt(struct rpc_clnt *clnt)
1000−{
1001− struct rpc_xprt_switch *xps;
1002− struct rpc_xprt *xprt;
1003−
1004− rcu_read_lock();
1005− xprt = xprt_get(rcu_dereference(clnt->cl_xprt));
1006− if (xprt) {
1007− atomic_long_inc(&xprt->queuelen);
1008− xps = rcu_dereference(clnt->cl_xpi.xpi_xpswitch);
1009− atomic_long_inc(&xps->xps_queuelen);
1010− }
1011− rcu_read_unlock();
1012−
1013− return xprt;
1014−}
1015−
1016997 static void
1017998 rpc_task_release_xprt(struct rpc_clnt *clnt, struct rpc_xprt *xprt)
1018999 {
@@ -1057,6 +1038,23 @@ void rpc_task_release_client(struct rpc_task *task) · 38 unmodified lines
10571038 }
10581039 }
10591040
1041+static struct rpc_xprt *
1042+rpc_task_get_first_xprt(struct rpc_clnt *clnt)
1043+{
1044+ struct rpc_xprt *xprt;
1045+
1046+ rcu_read_lock();
1047+ xprt = xprt_get(rcu_dereference(clnt->cl_xprt));
1048+ rcu_read_unlock();
1049+ return rpc_task_get_xprt(clnt, xprt);
1050+}
1051+
1052+static struct rpc_xprt *
1053+rpc_task_get_next_xprt(struct rpc_clnt *clnt)
1054+{
1055+ return rpc_task_get_xprt(clnt, xprt_iter_get_next(&clnt->cl_xpi));
1056+}
1057+
10601058 static
10611059 void rpc_task_set_transport(struct rpc_task *task, struct rpc_clnt *clnt)
10621060 {
@@ -1065,7 +1063,7 @@ void rpc_task_set_transport(struct rpc_task *task, struct rpc_clnt *clnt) · 2 unmodified lines
10651063 if (task->tk_flags & RPC_TASK_NO_ROUND_ROBIN)
10661064 task->tk_xprt = rpc_task_get_first_xprt(clnt);
10671065 else
1068− task->tk_xprt = rpc_task_get_xprt(clnt);
1066+ task->tk_xprt = rpc_task_get_next_xprt(clnt);
10691067 }
10701068
10711069 static
net/sunrpc/sched.c+2−1
@@ -1092,7 +1092,8 @@ static void rpc_init_task(struct rpc_task *task, const struct rpc_task_setup *ta · 1091 unmodified lines
10921092 /* Initialize workqueue for async tasks */
10931093 task->tk_workqueue = task_setup_data->workqueue;
10941094
1095− task->tk_xprt = xprt_get(task_setup_data->rpc_xprt);
1095+ task->tk_xprt = rpc_task_get_xprt(task_setup_data->rpc_client,
1096+ xprt_get(task_setup_data->rpc_xprt));
10961097
10971098 task->tk_op_cred = get_rpccred(task_setup_data->rpc_op_cred);
10981099

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t