History

KVM: Introduce pv check helpers

Introduce some pv check helpers for consistency.

Wanpeng Li committed 6 years ago

Commit a262bca1 parent fcd07f91 file · +24 −10Browse files

Unified · Split

arch/x86/kernel/kvm.c+24−10
@@ -425,7 +425,27 @@ static void __init sev_map_percpu_data(void) · 424 unmodified lines
425425 }
426426 }
427427
428+static bool pv_tlb_flush_supported(void)
429+{
430+ return (kvm_para_has_feature(KVM_FEATURE_PV_TLB_FLUSH) &&
431+ !kvm_para_has_hint(KVM_HINTS_REALTIME) &&
432+ kvm_para_has_feature(KVM_FEATURE_STEAL_TIME));
433+}
434+
428435 #ifdef CONFIG_SMP
436+
437+static bool pv_ipi_supported(void)
438+{
439+ return kvm_para_has_feature(KVM_FEATURE_PV_SEND_IPI);
440+}
441+
442+static bool pv_sched_yield_supported(void)
443+{
444+ return (kvm_para_has_feature(KVM_FEATURE_PV_SCHED_YIELD) &&
445+ !kvm_para_has_hint(KVM_HINTS_REALTIME) &&
446+ kvm_para_has_feature(KVM_FEATURE_STEAL_TIME));
447+}
448+
429449 #define KVM_IPI_CLUSTER_SIZE (2 * BITS_PER_LONG)
430450
431451 static void __send_ipi_mask(const struct cpumask *mask, int vector)
@@ -619,9 +639,7 @@ static void __init kvm_guest_init(void) · 187 unmodified lines
619639 pv_ops.time.steal_clock = kvm_steal_clock;
620640 }
621641
622− if (kvm_para_has_feature(KVM_FEATURE_PV_TLB_FLUSH) &&
623− !kvm_para_has_hint(KVM_HINTS_REALTIME) &&
624− kvm_para_has_feature(KVM_FEATURE_STEAL_TIME)) {
642+ if (pv_tlb_flush_supported()) {
625643 pv_ops.mmu.flush_tlb_others = kvm_flush_tlb_others;
626644 pv_ops.mmu.tlb_remove_table = tlb_remove_table;
627645 }
@@ -632,9 +650,7 @@ static void __init kvm_guest_init(void) · 4 unmodified lines
632650 #ifdef CONFIG_SMP
633651 smp_ops.smp_prepare_cpus = kvm_smp_prepare_cpus;
634652 smp_ops.smp_prepare_boot_cpu = kvm_smp_prepare_boot_cpu;
635− if (kvm_para_has_feature(KVM_FEATURE_PV_SCHED_YIELD) &&
636− !kvm_para_has_hint(KVM_HINTS_REALTIME) &&
637− kvm_para_has_feature(KVM_FEATURE_STEAL_TIME)) {
653+ if (pv_sched_yield_supported()) {
638654 smp_ops.send_call_func_ipi = kvm_smp_send_call_func_ipi;
639655 pr_info("KVM setup pv sched yield\n");
640656 }
@@ -700,7 +716,7 @@ static uint32_t __init kvm_detect(void) · 59 unmodified lines
700716 static void __init kvm_apic_init(void)
701717 {
702718 #if defined(CONFIG_SMP)
703− if (kvm_para_has_feature(KVM_FEATURE_PV_SEND_IPI))
719+ if (pv_ipi_supported())
704720 kvm_setup_pv_ipi();
705721 #endif
706722 }
@@ -739,9 +755,7 @@ static __init int kvm_setup_pv_tlb_flush(void) · 32 unmodified lines
739755 if (!kvm_para_available() || nopv)
740756 return 0;
741757
742− if (kvm_para_has_feature(KVM_FEATURE_PV_TLB_FLUSH) &&
743− !kvm_para_has_hint(KVM_HINTS_REALTIME) &&
744− kvm_para_has_feature(KVM_FEATURE_STEAL_TIME)) {
758+ if (pv_tlb_flush_supported()) {
745759 for_each_possible_cpu(cpu) {
746760 zalloc_cpumask_var_node(per_cpu_ptr(&__pv_tlb_mask, cpu),
747761 GFP_KERNEL, cpu_to_node(cpu));