History

coccinelle: deref_null: avoid useless computation

The effect of the rules ifm1, pr11, and pr12 is only used in the final rule, which depends on context && !org && !report. Thus these rules should only be performed in those circumstances.

Julia Lawall committed 8 years ago

Commit a2b0fe71 parent e856f3a1 file · +3 −3Browse files

Unified · Split

scripts/coccinelle/null/deref_null.cocci+3−3
@@ -212,7 +212,7 @@ else S3 · 211 unmodified lines
212// The following three rules are duplicates of ifm, pr1 and pr2 respectively.212// The following three rules are duplicates of ifm, pr1 and pr2 respectively.
213// It is need because the previous rule as already made a "change".213// It is need because the previous rule as already made a "change".
214 214
215@ifm1@215@ifm1 depends on context && !org && !report@
216expression *E;216expression *E;
217statement S1,S2;217statement S1,S2;
218position p1;218position p1;
@@ -220,7 +220,7 @@ position p1; · 1 unmodified line
220 220
221if@p1 ((E == NULL && ...) || ...) S1 else S2221if@p1 ((E == NULL && ...) || ...) S1 else S2
222 222
223@pr11 expression@223@pr11 depends on context && !org && !report expression@
224expression *ifm1.E;224expression *ifm1.E;
225identifier f;225identifier f;
226position p1;226position p1;
@@ -228,7 +228,7 @@ position p1; · 1 unmodified line
228 228
229 (E != NULL && ...) ? <+...E->f@p1...+> : ...229 (E != NULL && ...) ? <+...E->f@p1...+> : ...
230 230
231@pr12 expression@231@pr12 depends on context && !org && !report expression@
232expression *ifm1.E;232expression *ifm1.E;
233identifier f;233identifier f;
234position p2;234position p2;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t