History

mmc: slot-gpio: Remove override_active_level on WP

The argument "override_active_level" made it possible to enforce a specific polarity on the write-protect GPIO line. All callers in the kernel pass "false" to this call after I have converted all drivers to use GPIO machine descriptors, so remove the argument and clean out this. This kind of polarity inversion should be handled by the GPIO descriptor inside the GPIO library if needed. This rids us of one instance of the kludgy calls into the gpiod_get_raw_value() API.

Linus Walleij committed 7 years ago

Commit a2b760a1 parent 9cda3e79 files · +9 −16Browse files

Showing the changes to include/linux (1 of 9 files). Show all

Unified · Split

include/linux/mmc/slot-gpio.h+1−1
@@ -22,7 +22,7 @@ int mmc_gpiod_request_cd(struct mmc_host *host, const char *con_id, · 21 unmodified lines
22 unsigned int idx, bool override_active_level,22 unsigned int idx, bool override_active_level,
23 unsigned int debounce, bool *gpio_invert);23 unsigned int debounce, bool *gpio_invert);
24int mmc_gpiod_request_ro(struct mmc_host *host, const char *con_id,24int mmc_gpiod_request_ro(struct mmc_host *host, const char *con_id,
25 unsigned int idx, bool override_active_level,25 unsigned int idx,
26 unsigned int debounce, bool *gpio_invert);26 unsigned int debounce, bool *gpio_invert);
27void mmc_gpio_set_cd_isr(struct mmc_host *host,27void mmc_gpio_set_cd_isr(struct mmc_host *host,
28 irqreturn_t (*isr)(int irq, void *dev_id));28 irqreturn_t (*isr)(int irq, void *dev_id));

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t