History

Merge tag 'omap-fixes-a-for-3.5rc' of git://git.kernel.org/pub/scm/linux/kernel/git/pjw/omap-pending into fixes

From Paul Walmsley (as per Tony Lindgren's request): "Some uncontroversial OMAP clock, hwmod, and compiler warning fixes for 3.5-rc" * tag 'omap-fixes-a-for-3.5rc' of git://git.kernel.org/pub/scm/linux/kernel/git/pjw/omap-pending: ARM: OMAP4: hwmod data: Force HDMI in no-idle while enabled ARM: OMAP2+: mux: fix sparse warning ARM: OMAP2+: CM: increase the module disable timeout ARM: OMAP4: clock data: add clockdomains for clocks used as main clocks ARM: OMAP4: hwmod data: fix 32k sync timer idle modes ARM: OMAP4+: hwmod: fix issue causing IPs not going back to Smart-Standby ARM: OMAP: PM: Lock clocks list while generating summary

Olof Johansson committed 14 years ago

Commit a34a3b72 parents e23d709 dc57aef7 files · +28 −5Browse files

Unified · Split

7 files
  1. arch/arm/mach-omap2/clock44xx_data.c +5 −0
  2. arch/arm/mach-omap2/cm.h +11 −0
  3. arch/arm/mach-omap2/cminst44xx.c +2 −2
  4. arch/arm/mach-omap2/mux.c +1 −0
  5. arch/arm/mach-omap2/omap_hwmod.c +1 −1
  6. arch/arm/mach-omap2/omap_hwmod_44xx_data.c +6 −2
  7. arch/arm/plat-omap/clock.c +2 −0
arch/arm/mach-omap2/clock44xx_data.c+5−0
@@ -84,6 +84,7 @@ static struct clk slimbus_clk = { · 83 unmodified lines
8484
8585 static struct clk sys_32k_ck = {
8686 .name = "sys_32k_ck",
87+ .clkdm_name = "prm_clkdm",
8788 .rate = 32768,
8889 .ops = &clkops_null,
8990 };
@@ -512,6 +513,7 @@ static struct clk ddrphy_ck = { · 422 unmodified lines
512513 .name = "ddrphy_ck",
513514 .parent = &dpll_core_m2_ck,
514515 .ops = &clkops_null,
516+ .clkdm_name = "l3_emif_clkdm",
515517 .fixed_div = 2,
516518 .recalc = &omap_fixed_divisor_recalc,
517519 };
@@ -769,6 +771,7 @@ static const struct clksel dpll_mpu_m2_div[] = { · 251 unmodified lines
769771 static struct clk dpll_mpu_m2_ck = {
770772 .name = "dpll_mpu_m2_ck",
771773 .parent = &dpll_mpu_ck,
774+ .clkdm_name = "cm_clkdm",
772775 .clksel = dpll_mpu_m2_div,
773776 .clksel_reg = OMAP4430_CM_DIV_M2_DPLL_MPU,
774777 .clksel_mask = OMAP4430_DPLL_CLKOUT_DIV_MASK,
@@ -1149,6 +1152,7 @@ static const struct clksel l3_div_div[] = { · 374 unmodified lines
11491152 static struct clk l3_div_ck = {
11501153 .name = "l3_div_ck",
11511154 .parent = &div_core_ck,
1155+ .clkdm_name = "cm_clkdm",
11521156 .clksel = l3_div_div,
11531157 .clksel_reg = OMAP4430_CM_CLKSEL_CORE,
11541158 .clksel_mask = OMAP4430_CLKSEL_L3_MASK,
@@ -2824,6 +2828,7 @@ static const struct clksel trace_clk_div_div[] = { · 1669 unmodified lines
28242828 static struct clk trace_clk_div_ck = {
28252829 .name = "trace_clk_div_ck",
28262830 .parent = &pmd_trace_clk_mux_ck,
2831+ .clkdm_name = "emu_sys_clkdm",
28272832 .clksel = trace_clk_div_div,
28282833 .clksel_reg = OMAP4430_CM_EMU_DEBUGSS_CLKCTRL,
28292834 .clksel_mask = OMAP4430_CLKSEL_PMD_TRACE_CLK_MASK,
arch/arm/mach-omap2/cm.h+11−0
@@ -22,4 +22,15 @@ · 21 unmodified lines
2222 */
2323 #define MAX_MODULE_READY_TIME 2000
2424
25+/*
26+ * MAX_MODULE_DISABLE_TIME: max duration in microseconds to wait for
27+ * the PRCM to request that a module enter the inactive state in the
28+ * case of OMAP2 & 3. In the case of OMAP4 this is the max duration
29+ * in microseconds for the module to reach the inactive state from
30+ * a functional state.
31+ * XXX FSUSB on OMAP4430 takes ~4ms to idle after reset during
32+ * kernel init.
33+ */
34+#define MAX_MODULE_DISABLE_TIME 5000
35+
2536 #endif
arch/arm/mach-omap2/cminst44xx.c+2−2
@@ -313,9 +313,9 @@ int omap4_cminst_wait_module_idle(u8 part, u16 inst, s16 cdoffs, u16 clkctrl_off · 312 unmodified lines
313313
314314 omap_test_timeout((_clkctrl_idlest(part, inst, cdoffs, clkctrl_offs) ==
315315 CLKCTRL_IDLEST_DISABLED),
316− MAX_MODULE_READY_TIME, i);
316+ MAX_MODULE_DISABLE_TIME, i);
317317
318− return (i < MAX_MODULE_READY_TIME) ? 0 : -EBUSY;
318+ return (i < MAX_MODULE_DISABLE_TIME) ? 0 : -EBUSY;
319319 }
320320
321321 /**
arch/arm/mach-omap2/mux.c+1−0
@@ -41,6 +41,7 @@ · 40 unmodified lines
4141 #include "control.h"
4242 #include "mux.h"
4343 #include "prm.h"
44+#include "common.h"
4445
4546 #define OMAP_MUX_BASE_OFFSET 0x30 /* Offset from CTRL_BASE */
4647 #define OMAP_MUX_BASE_SZ 0x5ca
arch/arm/mach-omap2/omap_hwmod.c+1−1
@@ -530,7 +530,7 @@ static int _disable_wakeup(struct omap_hwmod *oh, u32 *v) · 529 unmodified lines
530530 if (oh->class->sysc->idlemodes & SIDLE_SMART_WKUP)
531531 _set_slave_idlemode(oh, HWMOD_IDLEMODE_SMART, v);
532532 if (oh->class->sysc->idlemodes & MSTANDBY_SMART_WKUP)
533− _set_master_standbymode(oh, HWMOD_IDLEMODE_SMART_WKUP, v);
533+ _set_master_standbymode(oh, HWMOD_IDLEMODE_SMART, v);
534534
535535 /* XXX test pwrdm_get_wken for this hwmod's subsystem */
536536
arch/arm/mach-omap2/omap_hwmod_44xx_data.c+6−2
@@ -393,8 +393,7 @@ static struct omap_hwmod_class_sysconfig omap44xx_counter_sysc = { · 392 unmodified lines
393393 .rev_offs = 0x0000,
394394 .sysc_offs = 0x0004,
395395 .sysc_flags = SYSC_HAS_SIDLEMODE,
396− .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
397− SIDLE_SMART_WKUP),
396+ .idlemodes = (SIDLE_FORCE | SIDLE_NO),
398397 .sysc_fields = &omap_hwmod_sysc_type1,
399398 };
400399
@@ -854,6 +853,11 @@ static struct omap_hwmod omap44xx_dss_hdmi_hwmod = { · 453 unmodified lines
854853 .name = "dss_hdmi",
855854 .class = &omap44xx_hdmi_hwmod_class,
856855 .clkdm_name = "l3_dss_clkdm",
856+ /*
857+ * HDMI audio requires to use no-idle mode. Hence,
858+ * set idle mode by software.
859+ */
860+ .flags = HWMOD_SWSUP_SIDLE,
857861 .mpu_irqs = omap44xx_dss_hdmi_irqs,
858862 .sdma_reqs = omap44xx_dss_hdmi_sdma_reqs,
859863 .main_clk = "dss_48mhz_clk",
arch/arm/plat-omap/clock.c+2−0
@@ -461,6 +461,7 @@ static int clk_dbg_show_summary(struct seq_file *s, void *unused) · 460 unmodified lines
461461 struct clk *c;
462462 struct clk *pa;
463463
464+ mutex_lock(&clocks_mutex);
464465 seq_printf(s, "%-30s %-30s %-10s %s\n",
465466 "clock-name", "parent-name", "rate", "use-count");
466467
@@ -469,6 +470,7 @@ static int clk_dbg_show_summary(struct seq_file *s, void *unused) · 2 unmodified lines
469470 seq_printf(s, "%-30s %-30s %-10lu %d\n",
470471 c->name, pa ? pa->name : "none", c->rate, c->usecount);
471472 }
473+ mutex_unlock(&clocks_mutex);
472474
473475 return 0;
474476 }