Spotted after a code review. Introduced by c12b395a46646bab69089ce7016ac78177f6001f (gre: Support GRE over IPv6).
Unified · Split
| @@ -1633,9 +1633,9 @@ static size_t ip6gre_get_size(const struct net_device *dev) · 1632 unmodified lines | ||
| 1633 | 1633 | /* IFLA_GRE_OKEY */ |
| 1634 | 1634 | nla_total_size(4) + |
| 1635 | 1635 | /* IFLA_GRE_LOCAL */ |
| 1636 | − nla_total_size(4) + | |
| 1636 | + nla_total_size(sizeof(struct in6_addr)) + | |
| 1637 | 1637 | /* IFLA_GRE_REMOTE */ |
| 1638 | − nla_total_size(4) + | |
| 1638 | + nla_total_size(sizeof(struct in6_addr)) + | |
| 1639 | 1639 | /* IFLA_GRE_TTL */ |
| 1640 | 1640 | nla_total_size(1) + |
| 1641 | 1641 | /* IFLA_GRE_TOS */ |
| @@ -1659,8 +1659,8 @@ static int ip6gre_fill_info(struct sk_buff *skb, const struct net_device *dev) · 17 unmodified lines | ||
| 1659 | 1659 | nla_put_be16(skb, IFLA_GRE_OFLAGS, p->o_flags) || |
| 1660 | 1660 | nla_put_be32(skb, IFLA_GRE_IKEY, p->i_key) || |
| 1661 | 1661 | nla_put_be32(skb, IFLA_GRE_OKEY, p->o_key) || |
| 1662 | − nla_put(skb, IFLA_GRE_LOCAL, sizeof(struct in6_addr), &p->raddr) || | |
| 1663 | − nla_put(skb, IFLA_GRE_REMOTE, sizeof(struct in6_addr), &p->laddr) || | |
| 1662 | + nla_put(skb, IFLA_GRE_LOCAL, sizeof(struct in6_addr), &p->laddr) || | |
| 1663 | + nla_put(skb, IFLA_GRE_REMOTE, sizeof(struct in6_addr), &p->raddr) || | |
| 1664 | 1664 | nla_put_u8(skb, IFLA_GRE_TTL, p->hop_limit) || |
| 1665 | 1665 | /*nla_put_u8(skb, IFLA_GRE_TOS, t->priority) ||*/ |
| 1666 | 1666 | nla_put_u8(skb, IFLA_GRE_ENCAP_LIMIT, p->encap_limit) || |