History

perf scripts python: exported-sql-viewer.py: Improve TreeModel abstraction

Instead of passing the tree root, get it from a method that can be implemented in any derived class.

Adrian Hunter committed 7 years ago

Commit a448ba21 parent a731cc41 file · +11 −6Browse files

Showing the changes to tools/perf/scripts/python (1 of 1 file). Show all

Unified · Split

tools/perf/scripts/python/exported-sql-viewer.py+11−6
@@ -167,9 +167,10 @@ class Thread(QThread): · 166 unmodified lines
167 167
168class TreeModel(QAbstractItemModel):168class TreeModel(QAbstractItemModel):
169 169
170 def __init__(self, root, parent=None):170 def __init__(self, glb, parent=None):
171 super(TreeModel, self).__init__(parent)171 super(TreeModel, self).__init__(parent)
172 self.root = root172 self.glb = glb
173 self.root = self.GetRoot()
173 self.last_row_read = 0174 self.last_row_read = 0
174 175
175 def Item(self, parent):176 def Item(self, parent):
@@ -562,8 +563,10 @@ class CallGraphRootItem(CallGraphLevelItemBase): · 386 unmodified lines
562class CallGraphModel(TreeModel):563class CallGraphModel(TreeModel):
563 564
564 def __init__(self, glb, parent=None):565 def __init__(self, glb, parent=None):
565 super(CallGraphModel, self).__init__(CallGraphRootItem(glb), parent)566 super(CallGraphModel, self).__init__(glb, parent)
566 self.glb = glb567
568 def GetRoot(self):
569 return CallGraphRootItem(self.glb)
567 570
568 def columnCount(self, parent=None):571 def columnCount(self, parent=None):
569 return 7572 return 7
@@ -1339,8 +1342,7 @@ class BranchModel(TreeModel): · 769 unmodified lines
1339 progress = Signal(object)1342 progress = Signal(object)
1340 1343
1341 def __init__(self, glb, event_id, where_clause, parent=None):1344 def __init__(self, glb, event_id, where_clause, parent=None):
1342 super(BranchModel, self).__init__(BranchRootItem(), parent)1345 super(BranchModel, self).__init__(glb, parent)
1343 self.glb = glb
1344 self.event_id = event_id1346 self.event_id = event_id
1345 self.more = True1347 self.more = True
1346 self.populated = 01348 self.populated = 0
@@ -1364,6 +1366,9 @@ class BranchModel(TreeModel): · 17 unmodified lines
1364 self.fetcher.done.connect(self.Update)1366 self.fetcher.done.connect(self.Update)
1365 self.fetcher.Fetch(glb_chunk_sz)1367 self.fetcher.Fetch(glb_chunk_sz)
1366 1368
1369 def GetRoot(self):
1370 return BranchRootItem()
1371
1367 def columnCount(self, parent=None):1372 def columnCount(self, parent=None):
1368 return 81373 return 8
1369 1374