History

perf scripts python: exported-sql-viewer.py: Improve TreeModel abstraction

Instead of passing the tree root, get it from a method that can be implemented in any derived class.

Adrian Hunter committed 7 years ago

Commit a448ba21 parent a731cc41 file · +11 −6Browse files

Showing the changes to tools/perf/scripts/python (1 of 1 file). Show all

Unified · Split

tools/perf/scripts/python/exported-sql-viewer.py+11−6
@@ -167,9 +167,10 @@ class Thread(QThread): · 166 unmodified lines
167167
168168 class TreeModel(QAbstractItemModel):
169169
170− def __init__(self, root, parent=None):
170+ def __init__(self, glb, parent=None):
171171 super(TreeModel, self).__init__(parent)
172− self.root = root
172+ self.glb = glb
173+ self.root = self.GetRoot()
173174 self.last_row_read = 0
174175
175176 def Item(self, parent):
@@ -562,8 +563,10 @@ class CallGraphRootItem(CallGraphLevelItemBase): · 386 unmodified lines
562563 class CallGraphModel(TreeModel):
563564
564565 def __init__(self, glb, parent=None):
565− super(CallGraphModel, self).__init__(CallGraphRootItem(glb), parent)
566− self.glb = glb
566+ super(CallGraphModel, self).__init__(glb, parent)
567+
568+ def GetRoot(self):
569+ return CallGraphRootItem(self.glb)
567570
568571 def columnCount(self, parent=None):
569572 return 7
@@ -1339,8 +1342,7 @@ class BranchModel(TreeModel): · 769 unmodified lines
13391342 progress = Signal(object)
13401343
13411344 def __init__(self, glb, event_id, where_clause, parent=None):
1342− super(BranchModel, self).__init__(BranchRootItem(), parent)
1343− self.glb = glb
1345+ super(BranchModel, self).__init__(glb, parent)
13441346 self.event_id = event_id
13451347 self.more = True
13461348 self.populated = 0
@@ -1364,6 +1366,9 @@ class BranchModel(TreeModel): · 17 unmodified lines
13641366 self.fetcher.done.connect(self.Update)
13651367 self.fetcher.Fetch(glb_chunk_sz)
13661368
1369+ def GetRoot(self):
1370+ return BranchRootItem()
1371+
13671372 def columnCount(self, parent=None):
13681373 return 8
13691374