'status' variable in ocfs2_global_read_info() is always != 0 when leaving the function because it happens to contain number of read bytes. Thus we always log error message although everything is OK. Since all error cases properly call mlog_errno() before jumping to out_err, there's no reason to call mlog_errno() on exit at all. This is a fallout of c1e8d35e (conversion of mlog_exit() calls).
Unified · Split
| @@ -399,8 +399,6 @@ int ocfs2_global_read_info(struct super_block *sb, int type) · 398 unmodified lines | |||
| 399 | msecs_to_jiffies(oinfo->dqi_syncms)); | 399 | msecs_to_jiffies(oinfo->dqi_syncms)); |
| 400 | 400 | ||
| 401 | out_err: | 401 | out_err: |
| 402 | if (status) | ||
| 403 | mlog_errno(status); | ||
| 404 | return status; | 402 | return status; |
| 405 | out_unlock: | 403 | out_unlock: |
| 406 | ocfs2_unlock_global_qf(oinfo, 0); | 404 | ocfs2_unlock_global_qf(oinfo, 0); |