History

net/mlx5e: Remove redundant check in CQE recovery flow of tx reporter

Remove check of recovery bit, in the beginning of the CQE recovery function. This test is already performed right before the reporter is invoked, when CQE error is detected.

Aya Levin committed 7 years ago

Commit a4e508c1 parent 276d1971 file · +0 −3Browse files

Unified · Split

drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c+0−3
@@ -76,9 +76,6 @@ static int mlx5e_tx_reporter_err_cqe_recover(struct mlx5e_txqsq *sq) · 75 unmodified lines
76 u8 state;76 u8 state;
77 int err;77 int err;
78 78
79 if (!test_bit(MLX5E_SQ_STATE_RECOVERING, &sq->state))
80 return 0;
81
82 err = mlx5_core_query_sq_state(mdev, sq->sqn, &state);79 err = mlx5_core_query_sq_state(mdev, sq->sqn, &state);
83 if (err) {80 if (err) {
84 netdev_err(dev, "Failed to query SQ 0x%x state. err = %d\n",81 netdev_err(dev, "Failed to query SQ 0x%x state. err = %d\n",

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t