There is a potential integer overflow in drm_mode_dirtyfb_ioctl() if userspace passes in a large num_clips. The call to kmalloc would allocate a small buffer, and the call to fb->funcs->dirty may result in a memory corruption.
Unified · Split
| @@ -1873,6 +1873,10 @@ int drm_mode_dirtyfb_ioctl(struct drm_device *dev, · 1872 unmodified lines | |||
| 1873 | } | 1873 | } |
| 1874 | 1874 | ||
| 1875 | if (num_clips && clips_ptr) { | 1875 | if (num_clips && clips_ptr) { |
| 1876 | if (num_clips < 0 || num_clips > DRM_MODE_FB_DIRTY_MAX_CLIPS) { | ||
| 1877 | ret = -EINVAL; | ||
| 1878 | goto out_err1; | ||
| 1879 | } | ||
| 1876 | clips = kzalloc(num_clips * sizeof(*clips), GFP_KERNEL); | 1880 | clips = kzalloc(num_clips * sizeof(*clips), GFP_KERNEL); |
| 1877 | if (!clips) { | 1881 | if (!clips) { |
| 1878 | ret = -ENOMEM; | 1882 | ret = -ENOMEM; |
| @@ -235,6 +235,8 @@ struct drm_mode_fb_cmd { · 234 unmodified lines | |||
| 235 | #define DRM_MODE_FB_DIRTY_ANNOTATE_FILL 0x02 | 235 | #define DRM_MODE_FB_DIRTY_ANNOTATE_FILL 0x02 |
| 236 | #define DRM_MODE_FB_DIRTY_FLAGS 0x03 | 236 | #define DRM_MODE_FB_DIRTY_FLAGS 0x03 |
| 237 | 237 | ||
| 238 | #define DRM_MODE_FB_DIRTY_MAX_CLIPS 256 | ||
| 239 | |||
| 238 | /* | 240 | /* |
| 239 | * Mark a region of a framebuffer as dirty. | 241 | * Mark a region of a framebuffer as dirty. |
| 240 | * | 242 | * |