Fix ~12 single-word typos in RCU code comments. [ paulmck: Apply feedback from Randy Dunlap. ] Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Unified · Split
| @@ -777,9 +777,9 @@ static bool srcu_might_be_idle(struct srcu_struct *ssp) · 776 unmodified lines | |||
| 777 | spin_unlock_irqrestore_rcu_node(sdp, flags); | 777 | spin_unlock_irqrestore_rcu_node(sdp, flags); |
| 778 | 778 | ||
| 779 | /* | 779 | /* |
| 780 | * No local callbacks, so probabalistically probe global state. | 780 | * No local callbacks, so probabilistically probe global state. |
| 781 | * Exact information would require acquiring locks, which would | 781 | * Exact information would require acquiring locks, which would |
| 782 | * kill scalability, hence the probabalistic nature of the probe. | 782 | * kill scalability, hence the probabilistic nature of the probe. |
| 783 | */ | 783 | */ |
| 784 | 784 | ||
| 785 | /* First, see if enough time has passed since the last GP. */ | 785 | /* First, see if enough time has passed since the last GP. */ |
| @@ -94,9 +94,9 @@ static void rcu_sync_func(struct rcu_head *rhp) · 93 unmodified lines | |||
| 94 | rcu_sync_call(rsp); | 94 | rcu_sync_call(rsp); |
| 95 | } else { | 95 | } else { |
| 96 | /* | 96 | /* |
| 97 | * We're at least a GP after the last rcu_sync_exit(); eveybody | 97 | * We're at least a GP after the last rcu_sync_exit(); everybody |
| 98 | * will now have observed the write side critical section. | 98 | * will now have observed the write side critical section. |
| 99 | * Let 'em rip!. | 99 | * Let 'em rip! |
| 100 | */ | 100 | */ |
| 101 | WRITE_ONCE(rsp->gp_state, GP_IDLE); | 101 | WRITE_ONCE(rsp->gp_state, GP_IDLE); |
| 102 | } | 102 | } |
| @@ -23,7 +23,7 @@ typedef void (*postgp_func_t)(struct rcu_tasks *rtp); · 22 unmodified lines | |||
| 23 | * struct rcu_tasks - Definition for a Tasks-RCU-like mechanism. | 23 | * struct rcu_tasks - Definition for a Tasks-RCU-like mechanism. |
| 24 | * @cbs_head: Head of callback list. | 24 | * @cbs_head: Head of callback list. |
| 25 | * @cbs_tail: Tail pointer for callback list. | 25 | * @cbs_tail: Tail pointer for callback list. |
| 26 | * @cbs_wq: Wait queue allowning new callback to get kthread's attention. | 26 | * @cbs_wq: Wait queue allowing new callback to get kthread's attention. |
| 27 | * @cbs_lock: Lock protecting callback list. | 27 | * @cbs_lock: Lock protecting callback list. |
| 28 | * @kthread_ptr: This flavor's grace-period/callback-invocation kthread. | 28 | * @kthread_ptr: This flavor's grace-period/callback-invocation kthread. |
| 29 | * @gp_func: This flavor's grace-period-wait function. | 29 | * @gp_func: This flavor's grace-period-wait function. |
| @@ -504,7 +504,7 @@ DEFINE_RCU_TASKS(rcu_tasks, rcu_tasks_wait_gp, call_rcu_tasks, "RCU Tasks"); · 474 unmodified lines | |||
| 504 | * or transition to usermode execution. As such, there are no read-side | 504 | * or transition to usermode execution. As such, there are no read-side |
| 505 | * primitives analogous to rcu_read_lock() and rcu_read_unlock() because | 505 | * primitives analogous to rcu_read_lock() and rcu_read_unlock() because |
| 506 | * this primitive is intended to determine that all tasks have passed | 506 | * this primitive is intended to determine that all tasks have passed |
| 507 | * through a safe state, not so much for data-strcuture synchronization. | 507 | * through a safe state, not so much for data-structure synchronization. |
| 508 | * | 508 | * |
| 509 | * See the description of call_rcu() for more detailed information on | 509 | * See the description of call_rcu() for more detailed information on |
| 510 | * memory ordering guarantees. | 510 | * memory ordering guarantees. |
| @@ -637,7 +637,7 @@ DEFINE_RCU_TASKS(rcu_tasks_rude, rcu_tasks_rude_wait_gp, call_rcu_tasks_rude, · 126 unmodified lines | |||
| 637 | * there are no read-side primitives analogous to rcu_read_lock() and | 637 | * there are no read-side primitives analogous to rcu_read_lock() and |
| 638 | * rcu_read_unlock() because this primitive is intended to determine | 638 | * rcu_read_unlock() because this primitive is intended to determine |
| 639 | * that all tasks have passed through a safe state, not so much for | 639 | * that all tasks have passed through a safe state, not so much for |
| 640 | * data-strcuture synchronization. | 640 | * data-structure synchronization. |
| 641 | * | 641 | * |
| 642 | * See the description of call_rcu() for more detailed information on | 642 | * See the description of call_rcu() for more detailed information on |
| 643 | * memory ordering guarantees. | 643 | * memory ordering guarantees. |
| @@ -1163,7 +1163,7 @@ static void exit_tasks_rcu_finish_trace(struct task_struct *t) · 519 unmodified lines | |||
| 1163 | * there are no read-side primitives analogous to rcu_read_lock() and | 1163 | * there are no read-side primitives analogous to rcu_read_lock() and |
| 1164 | * rcu_read_unlock() because this primitive is intended to determine | 1164 | * rcu_read_unlock() because this primitive is intended to determine |
| 1165 | * that all tasks have passed through a safe state, not so much for | 1165 | * that all tasks have passed through a safe state, not so much for |
| 1166 | * data-strcuture synchronization. | 1166 | * data-structure synchronization. |
| 1167 | * | 1167 | * |
| 1168 | * See the description of call_rcu() for more detailed information on | 1168 | * See the description of call_rcu() for more detailed information on |
| 1169 | * memory ordering guarantees. | 1169 | * memory ordering guarantees. |
| @@ -2489,7 +2489,7 @@ int rcutree_dead_cpu(unsigned int cpu) · 2488 unmodified lines | |||
| 2489 | 2489 | ||
| 2490 | /* | 2490 | /* |
| 2491 | * Invoke any RCU callbacks that have made it to the end of their grace | 2491 | * Invoke any RCU callbacks that have made it to the end of their grace |
| 2492 | * period. Thottle as specified by rdp->blimit. | 2492 | * period. Throttle as specified by rdp->blimit. |
| 2493 | */ | 2493 | */ |
| 2494 | static void rcu_do_batch(struct rcu_data *rdp) | 2494 | static void rcu_do_batch(struct rcu_data *rdp) |
| 2495 | { | 2495 | { |
| @@ -3848,7 +3848,7 @@ EXPORT_SYMBOL_GPL(start_poll_synchronize_rcu); · 1352 unmodified lines | |||
| 3848 | * | 3848 | * |
| 3849 | * If a full RCU grace period has elapsed since the earlier call from | 3849 | * If a full RCU grace period has elapsed since the earlier call from |
| 3850 | * which oldstate was obtained, return @true, otherwise return @false. | 3850 | * which oldstate was obtained, return @true, otherwise return @false. |
| 3851 | * If @false is returned, it is the caller's responsibilty to invoke this | 3851 | * If @false is returned, it is the caller's responsibility to invoke this |
| 3852 | * function later on until it does return @true. Alternatively, the caller | 3852 | * function later on until it does return @true. Alternatively, the caller |
| 3853 | * can explicitly wait for a grace period, for example, by passing @oldstate | 3853 | * can explicitly wait for a grace period, for example, by passing @oldstate |
| 3854 | * to cond_synchronize_rcu() or by directly invoking synchronize_rcu(). | 3854 | * to cond_synchronize_rcu() or by directly invoking synchronize_rcu(). |
| @@ -4094,7 +4094,7 @@ EXPORT_SYMBOL_GPL(rcu_barrier); · 239 unmodified lines | |||
| 4094 | /* | 4094 | /* |
| 4095 | * Propagate ->qsinitmask bits up the rcu_node tree to account for the | 4095 | * Propagate ->qsinitmask bits up the rcu_node tree to account for the |
| 4096 | * first CPU in a given leaf rcu_node structure coming online. The caller | 4096 | * first CPU in a given leaf rcu_node structure coming online. The caller |
| 4097 | * must hold the corresponding leaf rcu_node ->lock with interrrupts | 4097 | * must hold the corresponding leaf rcu_node ->lock with interrupts |
| 4098 | * disabled. | 4098 | * disabled. |
| 4099 | */ | 4099 | */ |
| 4100 | static void rcu_init_new_rnp(struct rcu_node *rnp_leaf) | 4100 | static void rcu_init_new_rnp(struct rcu_node *rnp_leaf) |
| @@ -153,7 +153,7 @@ struct rcu_data { · 152 unmodified lines | |||
| 153 | unsigned long gp_seq; /* Track rsp->gp_seq counter. */ | 153 | unsigned long gp_seq; /* Track rsp->gp_seq counter. */ |
| 154 | unsigned long gp_seq_needed; /* Track furthest future GP request. */ | 154 | unsigned long gp_seq_needed; /* Track furthest future GP request. */ |
| 155 | union rcu_noqs cpu_no_qs; /* No QSes yet for this CPU. */ | 155 | union rcu_noqs cpu_no_qs; /* No QSes yet for this CPU. */ |
| 156 | bool core_needs_qs; /* Core waits for quiesc state. */ | 156 | bool core_needs_qs; /* Core waits for quiescent state. */ |
| 157 | bool beenonline; /* CPU online at least once. */ | 157 | bool beenonline; /* CPU online at least once. */ |
| 158 | bool gpwrap; /* Possible ->gp_seq wrap. */ | 158 | bool gpwrap; /* Possible ->gp_seq wrap. */ |
| 159 | bool exp_deferred_qs; /* This CPU awaiting a deferred QS? */ | 159 | bool exp_deferred_qs; /* This CPU awaiting a deferred QS? */ |
| @@ -2857,7 +2857,7 @@ static void show_rcu_nocb_state(struct rcu_data *rdp) · 2856 unmodified lines | |||
| 2857 | waslocked = raw_spin_is_locked(&rdp->nocb_gp_lock); | 2857 | waslocked = raw_spin_is_locked(&rdp->nocb_gp_lock); |
| 2858 | wassleep = swait_active(&rdp->nocb_gp_wq); | 2858 | wassleep = swait_active(&rdp->nocb_gp_wq); |
| 2859 | if (!rdp->nocb_gp_sleep && !waslocked && !wassleep) | 2859 | if (!rdp->nocb_gp_sleep && !waslocked && !wassleep) |
| 2860 | return; /* Nothing untowards. */ | 2860 | return; /* Nothing untoward. */ |
| 2861 | 2861 | ||
| 2862 | pr_info(" nocb GP activity on CB-only CPU!!! %c%c%c %c\n", | 2862 | pr_info(" nocb GP activity on CB-only CPU!!! %c%c%c %c\n", |
| 2863 | "lL"[waslocked], | 2863 | "lL"[waslocked], |
| @@ -174,7 +174,7 @@ static inline bool spin_trylock(spinlock_t *lock) · 173 unmodified lines | |||
| 174 | } | 174 | } |
| 175 | 175 | ||
| 176 | struct completion { | 176 | struct completion { |
| 177 | /* Hopefuly this won't overflow. */ | 177 | /* Hopefully this won't overflow. */ |
| 178 | unsigned int count; | 178 | unsigned int count; |
| 179 | }; | 179 | }; |
| 180 | 180 | ||