History

samples/bpf: minor *_nb_free performance fix

Magnus Karlsson committed 8 years ago

Commit a65ea681 parent a412ef51 file · +5 −3Browse files

Unified · Split

samples/bpf/xdpsock_user.c+5−3
@@ -157,15 +157,15 @@ static const char pkt_data[] = · 156 unmodified lines
157157
158158 static inline u32 umem_nb_free(struct xdp_umem_uqueue *q, u32 nb)
159159 {
160− u32 free_entries = q->size - (q->cached_prod - q->cached_cons);
160+ u32 free_entries = q->cached_cons - q->cached_prod;
161161
162162 if (free_entries >= nb)
163163 return free_entries;
164164
165165 /* Refresh the local tail pointer */
166− q->cached_cons = *q->consumer;
166+ q->cached_cons = *q->consumer + q->size;
167167
168− return q->size - (q->cached_prod - q->cached_cons);
168+ return q->cached_cons - q->cached_prod;
169169 }
170170
171171 static inline u32 xq_nb_free(struct xdp_uqueue *q, u32 ndescs)
@@ -439,6 +439,7 @@ static struct xdp_umem *xdp_umem_configure(int sfd) · 267 unmodified lines
439439 umem->fq.producer = umem->fq.map + off.fr.producer;
440440 umem->fq.consumer = umem->fq.map + off.fr.consumer;
441441 umem->fq.ring = umem->fq.map + off.fr.desc;
442+ umem->fq.cached_cons = FQ_NUM_DESCS;
442443
443444 umem->cq.map = mmap(0, off.cr.desc +
444445 CQ_NUM_DESCS * sizeof(u64),
@@ -535,6 +536,7 @@ static struct xdpsock *xsk_configure(struct xdp_umem *umem) · 90 unmodified lines
535536 xsk->tx.producer = xsk->tx.map + off.tx.producer;
536537 xsk->tx.consumer = xsk->tx.map + off.tx.consumer;
537538 xsk->tx.ring = xsk->tx.map + off.tx.desc;
539+ xsk->tx.cached_cons = NUM_DESCS;
538540
539541 sxdp.sxdp_family = PF_XDP;
540542 sxdp.sxdp_ifindex = opt_ifindex;