History

perf/core: Fix reversed NULL check in perf_event_groups_less()

This NULL check is reversed so it leads to a Smatch warning and presumably a NULL dereference. kernel/events/core.c:1598 perf_event_groups_less() error: we previously assumed 'right->cgrp->css.cgroup' could be null (see line 1590)

Dan Carpenter committed 6 years ago

Commit a6763621 parent 90c91df1 file · +1 −1Browse files

Showing the changes to kernel (1 of 1 file). Show all

Unified · Split

kernel/events/core.c+1−1
@@ -1586,7 +1586,7 @@ perf_event_groups_less(struct perf_event *left, struct perf_event *right) · 1585 unmodified lines
15861586 */
15871587 return true;
15881588 }
1589− if (!right->cgrp || right->cgrp->css.cgroup) {
1589+ if (!right->cgrp || !right->cgrp->css.cgroup) {
15901590 /*
15911591 * Right has no cgroup but left does, no cgroups come
15921592 * first.

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t