It can happen that a commit message refers to an invalid commit id, because the referenced hash changed following a rebase, or simply by mistake. Add a check in checkpatch.pl which checks that an hash referenced by a Fixes tag, or just cited in the commit message, is a valid commit id. $ scripts/checkpatch.pl <<'EOF' Subject: [PATCH] test commit Sample test commit to test checkpatch.pl Commit 1da177e4c3f4 ("Linux-2.6.12-rc2") really exists, commit 0bba044c4ce7 ("tree") is valid but not a commit, while commit b4cc0b1c0cca ("unknown") is invalid. Fixes: f0cacc14cade ("unknown") Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") EOF WARNING: Unknown commit id '0bba044c4ce7', maybe rebased or not pulled? #8: commit 0bba044c4ce7 ("tree") is valid but not a commit, WARNING: Unknown commit id 'b4cc0b1c0cca', maybe rebased or not pulled? #9: while commit b4cc0b1c0cca ("unknown") is invalid. WARNING: Unknown commit id 'f0cacc14cade', maybe rebased or not pulled? #11: Fixes: f0cacc14cade ("unknown") total: 0 errors, 3 warnings, 4 lines checked
Showing the changes to scripts/checkpatch.pl (1 of 1 file). Show all
Unified · Split
| @@ -2900,6 +2900,17 @@ sub process { · 2899 unmodified lines | ||
| 2900 | 2900 | } |
| 2901 | 2901 | } |
| 2902 | 2902 | |
| 2903 | +# check for invalid commit id | |
| 2904 | + if ($in_commit_log && $line =~ /(^fixes:|\bcommit)\s+([0-9a-f]{6,40})\b/i) { | |
| 2905 | + my $id; | |
| 2906 | + my $description; | |
| 2907 | + ($id, $description) = git_commit_info($2, undef, undef); | |
| 2908 | + if (!defined($id)) { | |
| 2909 | + WARN("UNKNOWN_COMMIT_ID", | |
| 2910 | + "Unknown commit id '$2', maybe rebased or not pulled?\n" . $herecurr); | |
| 2911 | + } | |
| 2912 | + } | |
| 2913 | + | |
| 2903 | 2914 | # ignore non-hunk lines and lines being removed |
| 2904 | 2915 | next if (!$hunk_line || $line =~ /^-/); |
| 2905 | 2916 | |