Let's bring a bit of clarity on this 'region' field that is part of vm_bind operation struct. Rename and document to make it more than obvious that it is a region instance and not a mask and also that it should only be used with the prefetch operation itself.
Showing the changes to include/uapi/drm (1 of 2 files). Show all
Unified · Split
| @@ -673,8 +673,12 @@ struct drm_xe_vm_bind_op { · 672 unmodified lines | |||
| 673 | /** @flags: Bind flags */ | 673 | /** @flags: Bind flags */ |
| 674 | __u32 flags; | 674 | __u32 flags; |
| 675 | 675 | ||
| 676 | /** @mem_region: Memory region to prefetch VMA to, instance not a mask */ | 676 | /** |
| 677 | __u32 region; | 677 | * @prefetch_mem_region_instance: Memory region to prefetch VMA to. |
| 678 | * It is a region instance, not a mask. | ||
| 679 | * To be used only with %DRM_XE_VM_BIND_OP_PREFETCH operation. | ||
| 680 | */ | ||
| 681 | __u32 prefetch_mem_region_instance; | ||
| 678 | 682 | ||
| 679 | /** @reserved: Reserved */ | 683 | /** @reserved: Reserved */ |
| 680 | __u64 reserved[2]; | 684 | __u64 reserved[2]; |