The return of _nohz_idle_balance() is not used anymore so we can remove it
Unified · Split
| @@ -10354,10 +10354,8 @@ out: · 10353 unmodified lines | |||
| 10354 | * Internal function that runs load balance for all idle cpus. The load balance | 10354 | * Internal function that runs load balance for all idle cpus. The load balance |
| 10355 | * can be a simple update of blocked load or a complete load balance with | 10355 | * can be a simple update of blocked load or a complete load balance with |
| 10356 | * tasks movement depending of flags. | 10356 | * tasks movement depending of flags. |
| 10357 | * The function returns false if the loop has stopped before running | ||
| 10358 | * through all idle CPUs. | ||
| 10359 | */ | 10357 | */ |
| 10360 | static bool _nohz_idle_balance(struct rq *this_rq, unsigned int flags, | 10358 | static void _nohz_idle_balance(struct rq *this_rq, unsigned int flags, |
| 10361 | enum cpu_idle_type idle) | 10359 | enum cpu_idle_type idle) |
| 10362 | { | 10360 | { |
| 10363 | /* Earliest time when we have to do rebalance again */ | 10361 | /* Earliest time when we have to do rebalance again */ |
| @@ -10367,7 +10365,6 @@ static bool _nohz_idle_balance(struct rq *this_rq, unsigned int flags, · 3 unmodified lines | |||
| 10367 | int update_next_balance = 0; | 10365 | int update_next_balance = 0; |
| 10368 | int this_cpu = this_rq->cpu; | 10366 | int this_cpu = this_rq->cpu; |
| 10369 | int balance_cpu; | 10367 | int balance_cpu; |
| 10370 | int ret = false; | ||
| 10371 | struct rq *rq; | 10368 | struct rq *rq; |
| 10372 | 10369 | ||
| 10373 | SCHED_WARN_ON((flags & NOHZ_KICK_MASK) == NOHZ_BALANCE_KICK); | 10370 | SCHED_WARN_ON((flags & NOHZ_KICK_MASK) == NOHZ_BALANCE_KICK); |
| @@ -10447,15 +10444,10 @@ static bool _nohz_idle_balance(struct rq *this_rq, unsigned int flags, · 73 unmodified lines | |||
| 10447 | WRITE_ONCE(nohz.next_blocked, | 10444 | WRITE_ONCE(nohz.next_blocked, |
| 10448 | now + msecs_to_jiffies(LOAD_AVG_PERIOD)); | 10445 | now + msecs_to_jiffies(LOAD_AVG_PERIOD)); |
| 10449 | 10446 | ||
| 10450 | /* The full idle balance loop has been done */ | ||
| 10451 | ret = true; | ||
| 10452 | |||
| 10453 | abort: | 10447 | abort: |
| 10454 | /* There is still blocked load, enable periodic update */ | 10448 | /* There is still blocked load, enable periodic update */ |
| 10455 | if (has_blocked_load) | 10449 | if (has_blocked_load) |
| 10456 | WRITE_ONCE(nohz.has_blocked, 1); | 10450 | WRITE_ONCE(nohz.has_blocked, 1); |
| 10457 | |||
| 10458 | return ret; | ||
| 10459 | } | 10451 | } |
| 10460 | 10452 | ||
| 10461 | /* | 10453 | /* |