History

HID: i2c: use generic hidinput_input_event()

HID core provides the same functionality, so drop the custom handler. Besides, the current handler doesn't schedule any outgoing report so it did not work, anyway.

David Herrmann committed 13 years ago

Commit ac126f41 parent bfde79c1 file · +0 −24Browse files

Unified · Split

drivers/hid/i2c-hid/i2c-hid.c+0−24
@@ -756,29 +756,6 @@ static int i2c_hid_power(struct hid_device *hid, int lvl) · 755 unmodified lines
756 return ret;756 return ret;
757}757}
758 758
759static int i2c_hid_hidinput_input_event(struct input_dev *dev,
760 unsigned int type, unsigned int code, int value)
761{
762 struct hid_device *hid = input_get_drvdata(dev);
763 struct hid_field *field;
764 int offset;
765
766 if (type == EV_FF)
767 return input_ff_event(dev, type, code, value);
768
769 if (type != EV_LED)
770 return -1;
771
772 offset = hidinput_find_field(hid, type, code, &field);
773
774 if (offset == -1) {
775 hid_warn(dev, "event field not found\n");
776 return -1;
777 }
778
779 return hid_set_field(field, offset, value);
780}
781
782static struct hid_ll_driver i2c_hid_ll_driver = {759static struct hid_ll_driver i2c_hid_ll_driver = {
783 .parse = i2c_hid_parse,760 .parse = i2c_hid_parse,
784 .start = i2c_hid_start,761 .start = i2c_hid_start,
@@ -787,7 +764,6 @@ static struct hid_ll_driver i2c_hid_ll_driver = { · 2 unmodified lines
787 .close = i2c_hid_close,764 .close = i2c_hid_close,
788 .power = i2c_hid_power,765 .power = i2c_hid_power,
789 .request = i2c_hid_request,766 .request = i2c_hid_request,
790 .hidinput_input_event = i2c_hid_hidinput_input_event,
791};767};
792 768
793static int i2c_hid_init_irq(struct i2c_client *client)769static int i2c_hid_init_irq(struct i2c_client *client)

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t