As pointed out by Jakub Kicinski here: http://lore.kernel.org/r/20201009175751.5c54097f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com this patch addresses the remarked issues: - remove empty line in comment - remove default=y for CAN_ISOTP in Kconfig - make use of pr_notice_once() - use GFP_ATOMIC instead of gfp_any() in soft hrtimer context The version strings in the CAN subsystem are removed by a separate patch.
Showing the changes to include/uapi/linux/can (1 of 3 files). Show all
Unified · Split
| @@ -160,7 +160,6 @@ struct can_isotp_ll_options { · 159 unmodified lines | |||
| 160 | * these default settings can be changed via sockopts. | 160 | * these default settings can be changed via sockopts. |
| 161 | * For that reason the STmin value is intentionally _not_ checked for | 161 | * For that reason the STmin value is intentionally _not_ checked for |
| 162 | * consistency and copied directly into the flow control (FC) frame. | 162 | * consistency and copied directly into the flow control (FC) frame. |
| 163 | * | ||
| 164 | */ | 163 | */ |
| 165 | 164 | ||
| 166 | #endif /* !_UAPI_CAN_ISOTP_H */ | 165 | #endif /* !_UAPI_CAN_ISOTP_H */ |