The IMG PDC watchdog driver heartbeat module parameter has no default so it is initialised to zero. This results in the following warning during probe: imgpdc-wdt 2006000.wdt: Initial timeout out of range! setting max timeout The module parameter description implies that the default value should be PDC_WDT_DEF_TIMEOUT, which isn't yet used, so initialise it to that. Also tweak the heartbeat module parameter description for consistency.
Unified · Split
| @@ -42,10 +42,10 @@ · 41 unmodified lines | ||
| 42 | 42 | #define PDC_WDT_MIN_TIMEOUT 1 |
| 43 | 43 | #define PDC_WDT_DEF_TIMEOUT 64 |
| 44 | 44 | |
| 45 | −static int heartbeat; | |
| 45 | +static int heartbeat = PDC_WDT_DEF_TIMEOUT; | |
| 46 | 46 | module_param(heartbeat, int, 0); |
| 47 | −MODULE_PARM_DESC(heartbeat, "Watchdog heartbeats in seconds. " | |
| 48 | − "(default = " __MODULE_STRING(PDC_WDT_DEF_TIMEOUT) ")"); | |
| 47 | +MODULE_PARM_DESC(heartbeat, "Watchdog heartbeats in seconds " | |
| 48 | + "(default=" __MODULE_STRING(PDC_WDT_DEF_TIMEOUT) ")"); | |
| 49 | 49 | |
| 50 | 50 | static bool nowayout = WATCHDOG_NOWAYOUT; |
| 51 | 51 | module_param(nowayout, bool, 0); |