History

ceph: Remove osd_client deadcode

osd_req_op_extent_osd_data_pagelist() was added in 2013 as part of commit a4ce40a9a7c1 ("libceph: combine initializing and setting osd data") but never used. The last use of osd_req_op_cls_request_data_pagelist() was removed in 2017's commit ecd4a68a26a2 ("rbd: switch rbd_obj_method_sync() to ceph_osdc_call()") Remove them.

Dr. David Alan Gilbert committed 1 year ago

Commit aed06d31 parent 38fec102 files · +0 −29Browse files

Unified · Split

2 files
  1. include/linux/ceph/osd_client.h +0 −6
  2. net/ceph/osd_client.c +0 −23
include/linux/ceph/osd_client.h+0−6
@@ -490,9 +490,6 @@ extern void osd_req_op_extent_osd_data_pages(struct ceph_osd_request *, · 489 unmodified lines
490490 struct page **pages, u64 length,
491491 u32 alignment, bool pages_from_pool,
492492 bool own_pages);
493−extern void osd_req_op_extent_osd_data_pagelist(struct ceph_osd_request *,
494− unsigned int which,
495− struct ceph_pagelist *pagelist);
496493 #ifdef CONFIG_BLOCK
497494 void osd_req_op_extent_osd_data_bio(struct ceph_osd_request *osd_req,
498495 unsigned int which,
@@ -509,9 +506,6 @@ void osd_req_op_extent_osd_data_bvec_pos(struct ceph_osd_request *osd_req, · 10 unmodified lines
509506 void osd_req_op_extent_osd_iter(struct ceph_osd_request *osd_req,
510507 unsigned int which, struct iov_iter *iter);
511508
512−extern void osd_req_op_cls_request_data_pagelist(struct ceph_osd_request *,
513− unsigned int which,
514− struct ceph_pagelist *pagelist);
515509 extern void osd_req_op_cls_request_data_pages(struct ceph_osd_request *,
516510 unsigned int which,
517511 struct page **pages, u64 length,
net/ceph/osd_client.c+0−23
@@ -220,16 +220,6 @@ void osd_req_op_extent_osd_data_pages(struct ceph_osd_request *osd_req, · 219 unmodified lines
220220 }
221221 EXPORT_SYMBOL(osd_req_op_extent_osd_data_pages);
222222
223−void osd_req_op_extent_osd_data_pagelist(struct ceph_osd_request *osd_req,
224− unsigned int which, struct ceph_pagelist *pagelist)
225−{
226− struct ceph_osd_data *osd_data;
227−
228− osd_data = osd_req_op_data(osd_req, which, extent, osd_data);
229− ceph_osd_data_pagelist_init(osd_data, pagelist);
230−}
231−EXPORT_SYMBOL(osd_req_op_extent_osd_data_pagelist);
232−
233223 #ifdef CONFIG_BLOCK
234224 void osd_req_op_extent_osd_data_bio(struct ceph_osd_request *osd_req,
235225 unsigned int which,
@@ -297,19 +287,6 @@ static void osd_req_op_cls_request_info_pagelist( · 61 unmodified lines
297287 ceph_osd_data_pagelist_init(osd_data, pagelist);
298288 }
299289
300−void osd_req_op_cls_request_data_pagelist(
301− struct ceph_osd_request *osd_req,
302− unsigned int which, struct ceph_pagelist *pagelist)
303−{
304− struct ceph_osd_data *osd_data;
305−
306− osd_data = osd_req_op_data(osd_req, which, cls, request_data);
307− ceph_osd_data_pagelist_init(osd_data, pagelist);
308− osd_req->r_ops[which].cls.indata_len += pagelist->length;
309− osd_req->r_ops[which].indata_len += pagelist->length;
310−}
311−EXPORT_SYMBOL(osd_req_op_cls_request_data_pagelist);
312−
313290 void osd_req_op_cls_request_data_pages(struct ceph_osd_request *osd_req,
314291 unsigned int which, struct page **pages, u64 length,
315292 u32 alignment, bool pages_from_pool, bool own_pages)

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t