It is useless to create a hci_conn object if on error status as the result would be it being freed in the process and anyway it is likely the result of controller and host stack being out of sync.
Unified · Split
| @@ -3075,6 +3075,12 @@ static void hci_conn_complete_evt(struct hci_dev *hdev, void *data, · 3074 unmodified lines | ||
| 3075 | 3075 | |
| 3076 | 3076 | conn = hci_conn_hash_lookup_ba(hdev, ev->link_type, &ev->bdaddr); |
| 3077 | 3077 | if (!conn) { |
| 3078 | + /* In case of error status and there is no connection pending | |
| 3079 | + * just unlock as there is nothing to cleanup. | |
| 3080 | + */ | |
| 3081 | + if (ev->status) | |
| 3082 | + goto unlock; | |
| 3083 | + | |
| 3078 | 3084 | /* Connection may not exist if auto-connected. Check the bredr |
| 3079 | 3085 | * allowlist to see if this device is allowed to auto connect. |
| 3080 | 3086 | * If link is an ACL type, create a connection class |
| @@ -5542,6 +5548,12 @@ static void le_conn_complete_evt(struct hci_dev *hdev, u8 status, · 2461 unmodified lines | ||
| 5542 | 5548 | |
| 5543 | 5549 | conn = hci_lookup_le_connect(hdev); |
| 5544 | 5550 | if (!conn) { |
| 5551 | + /* In case of error status and there is no connection pending | |
| 5552 | + * just unlock as there is nothing to cleanup. | |
| 5553 | + */ | |
| 5554 | + if (status) | |
| 5555 | + goto unlock; | |
| 5556 | + | |
| 5545 | 5557 | conn = hci_conn_add(hdev, LE_LINK, bdaddr, role); |
| 5546 | 5558 | if (!conn) { |
| 5547 | 5559 | bt_dev_err(hdev, "no memory for new connection"); |