u32_change() copies the user-provided tc_u32_sel.offshift (unsigned char, 0-255) into the kernel knode object without bounds validation. When a packet later hits u32_classify() with TC_U32_VAROFFSET set, it evaluates `ntohs(offmask & *data) >> offshift` where the left operand is a 16-bit value promoted to a 32-bit int. Any offshift >= 32 is undefined behavior per C11 6.5.7p3, triggerable by an unprivileged user via user/network namespaces. UBSAN: shift-out-of-bounds in net/sched/cls_u32.c:236:43 shift exponent 32 is too large for 32-bit type int Fix this by rejecting offshift >= 16 during filter creation in u32_change().
Unified · Split
| @@ -1107,6 +1107,13 @@ static int u32_change(struct net *net, struct sk_buff *in_skb, · 1106 unmodified lines | |||
| 1107 | goto erridr; | 1107 | goto erridr; |
| 1108 | } | 1108 | } |
| 1109 | 1109 | ||
| 1110 | if (s->offshift >= 16) { | ||
| 1111 | NL_SET_ERR_MSG_MOD(extack, | ||
| 1112 | "offshift must be less than 16"); | ||
| 1113 | err = -EINVAL; | ||
| 1114 | goto erridr; | ||
| 1115 | } | ||
| 1116 | |||
| 1110 | n = kzalloc_flex(*n, sel.keys, s->nkeys); | 1117 | n = kzalloc_flex(*n, sel.keys, s->nkeys); |
| 1111 | if (n == NULL) { | 1118 | if (n == NULL) { |
| 1112 | err = -ENOBUFS; | 1119 | err = -ENOBUFS; |