History

bpf: Prevent memory disambiguation attack

Detect code patterns where malicious 'speculative store bypass' can be used and sanitize such patterns. 39: (bf) r3 = r10 40: (07) r3 += -216 41: (79) r8 = *(u64 *)(r7 +0) // slow read 42: (7a) *(u64 *)(r10 -72) = 0 // verifier inserts this instruction 43: (7b) *(u64 *)(r8 +0) = r3 // this store becomes slow due to r8 44: (79) r1 = *(u64 *)(r6 +0) // cpu speculatively executes this load 45: (71) r2 = *(u8 *)(r1 +0) // speculatively arbitrary 'load byte' // is now sanitized Above code after x86 JIT becomes: e5: mov %rbp,%rdx e8: add $0xffffffffffffff28,%rdx ef: mov 0x0(%r13),%r14 f3: movq $0x0,-0x48(%rbp) fb: mov %rdx,0x0(%r14) ff: mov 0x0(%rbx),%rdi 103: movzbq 0x0(%rdi),%rsi

Alexei Starovoitov committed 8 years ago

Commit af86ca41 parent 240da952 files · +57 −3Browse files

Showing the changes to include (1 of 2 files). Show all

Unified · Split

include/linux/bpf_verifier.h+1−0
@@ -146,6 +146,7 @@ struct bpf_insn_aux_data { · 145 unmodified lines
146 s32 call_imm; /* saved imm field of call insn */146 s32 call_imm; /* saved imm field of call insn */
147 };147 };
148 int ctx_field_size; /* the ctx field size for load insn, maybe 0 */148 int ctx_field_size; /* the ctx field size for load insn, maybe 0 */
149 int sanitize_stack_off; /* stack slot to be cleared */
149 bool seen; /* this insn was processed by the verifier */150 bool seen; /* this insn was processed by the verifier */
150};151};
151 152