History

Revert "drm/i915/uapi: expose GTT alignment"

The process for merging uAPI is to have UMD side ready and reviewed and merged before merging. Revert for now until that is ready. This reverts commit d54576a074a29d4901d0a693cd84e1a89057f694.

Matthew Auld committed 4 years ago

Commit b0feda91 parent a7ac9d82 files · +2 −28Browse files

Showing the changes to include/uapi (1 of 2 files). Show all

Unified · Split

include/uapi/drm/i915_drm.h+2−27
@@ -3346,33 +3346,8 @@ struct drm_i915_memory_region_info { · 3345 unmodified lines
3346 /** @region: The class:instance pair encoding */3346 /** @region: The class:instance pair encoding */
3347 struct drm_i915_gem_memory_class_instance region;3347 struct drm_i915_gem_memory_class_instance region;
3348 3348
3349 union {3349 /** @rsvd0: MBZ */
3350 /** @rsvd0: MBZ */3350 __u32 rsvd0;
3351 __u32 rsvd0;
3352 /**
3353 * @gtt_alignment:
3354 *
3355 * The minimum required GTT alignment for this type of memory.
3356 * When allocating a GTT address it must be aligned to this
3357 * value or larger. On some platforms the kernel might opt to
3358 * using 64K pages for I915_MEMORY_CLASS_DEVICE, where 64K GTT
3359 * pages can then be used if we also use 64K GTT alignment.
3360 *
3361 * NOTE: If this is zero then this must be an older
3362 * kernel which lacks support for this field.
3363 *
3364 * Side note: For larger objects (especially for
3365 * I915_MEMORY_CLASS_DEVICE), like 2M+ in size, userspace should
3366 * consider potentially bumping the GTT alignment to say 2M,
3367 * which could potentially increase the likelihood of the kernel
3368 * being able to utilise 2M GTT pages underneath, if the layout
3369 * of the physical pages allows it. On some configurations we
3370 * can then also use a more efficient page-table layout, if we
3371 * can't use the more desirable 2M GTT page, so long as we know
3372 * that the entire page-table will be used by this object.
3373 */
3374 __u32 gtt_alignment;
3375 };
3376 3351
3377 /**3352 /**
3378 * @probed_size: Memory probed by the driver3353 * @probed_size: Memory probed by the driver