History

irqchip/gic-v4: Use Inner-Shareable attributes for virtual pending tables

There is no special reason to set virtual LPI pending table as non-shareable. If we choose to hard code the shareability without probing, Inner-Shareable is likely to be a better choice, as the VPEs can move around and benefit from having the redistributors snooping each other's cache, if that's something they can do. Furthermore, Hisilicon hip08 ends up with unspecified errors when mixing shareability attributes. So let's move to IS attributes for the VPT. This has also been tested on D05 and didn't show any regression.

Heyi Guo committed 6 years ago

Commit b2cb11f1 parent 486562d2 files · +4 −1Browse files

Unified · Split

2 files
  1. drivers/irqchip/irq-gic-v3-its.c +1 −1
  2. include/linux/irqchip/arm-gic-v3.h +3 −0
drivers/irqchip/irq-gic-v3-its.c+1−1
@@ -3560,7 +3560,7 @@ static void its_vpe_schedule(struct its_vpe *vpe) · 3559 unmodified lines
3560 val = virt_to_phys(page_address(vpe->vpt_page)) &3560 val = virt_to_phys(page_address(vpe->vpt_page)) &
3561 GENMASK_ULL(51, 16);3561 GENMASK_ULL(51, 16);
3562 val |= GICR_VPENDBASER_RaWaWb;3562 val |= GICR_VPENDBASER_RaWaWb;
3563 val |= GICR_VPENDBASER_NonShareable;3563 val |= GICR_VPENDBASER_InnerShareable;
3564 /*3564 /*
3565 * There is no good way of finding out if the pending table is3565 * There is no good way of finding out if the pending table is
3566 * empty as we can race against the doorbell interrupt very3566 * empty as we can race against the doorbell interrupt very
include/linux/irqchip/arm-gic-v3.h+3−0
@@ -320,6 +320,9 @@ · 319 unmodified lines
320#define GICR_VPENDBASER_NonShareable \320#define GICR_VPENDBASER_NonShareable \
321 GIC_BASER_SHAREABILITY(GICR_VPENDBASER, NonShareable)321 GIC_BASER_SHAREABILITY(GICR_VPENDBASER, NonShareable)
322 322
323#define GICR_VPENDBASER_InnerShareable \
324 GIC_BASER_SHAREABILITY(GICR_VPENDBASER, InnerShareable)
325
323#define GICR_VPENDBASER_nCnB GIC_BASER_CACHEABILITY(GICR_VPENDBASER, INNER, nCnB)326#define GICR_VPENDBASER_nCnB GIC_BASER_CACHEABILITY(GICR_VPENDBASER, INNER, nCnB)
324#define GICR_VPENDBASER_nC GIC_BASER_CACHEABILITY(GICR_VPENDBASER, INNER, nC)327#define GICR_VPENDBASER_nC GIC_BASER_CACHEABILITY(GICR_VPENDBASER, INNER, nC)
325#define GICR_VPENDBASER_RaWt GIC_BASER_CACHEABILITY(GICR_VPENDBASER, INNER, RaWt)328#define GICR_VPENDBASER_RaWt GIC_BASER_CACHEABILITY(GICR_VPENDBASER, INNER, RaWt)

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t