History

kbuild: Get rid of KBUILD_STR

The compiler can accept -DKBUILD_MODNAME="foo", it's just a matter of quoting. That way, we reduce the gcc command line a bit.

Michal Marek committed 10 years ago

Commit b42841b1 parent e0f41e51 file · +4 −4Browse files

Showing the changes to scripts (1 of 1 file). Show all

Unified · Split

scripts/Makefile.lib+4−4
@@ -96,10 +96,10 @@ obj-dirs := $(addprefix $(obj)/,$(obj-dirs)) · 95 unmodified lines
96# Note: Files that end up in two or more modules are compiled without the96# Note: Files that end up in two or more modules are compiled without the
97# KBUILD_MODNAME definition. The reason is that any made-up name would97# KBUILD_MODNAME definition. The reason is that any made-up name would
98# differ in different configs.98# differ in different configs.
99name-fix = $(subst $(comma),_,$(subst -,_,$1))99name-fix = $(squote)$(quote)$(subst $(comma),_,$(subst -,_,$1))$(quote)$(squote)
100basename_flags = -D"KBUILD_BASENAME=KBUILD_STR($(call name-fix,$(basetarget)))"100basename_flags = -DKBUILD_BASENAME=$(call name-fix,$(basetarget))
101modname_flags = $(if $(filter 1,$(words $(modname))),\101modname_flags = $(if $(filter 1,$(words $(modname))),\
102 -D"KBUILD_MODNAME=KBUILD_STR($(call name-fix,$(modname)))")102 -DKBUILD_MODNAME=$(call name-fix,$(modname)))
103 103
104orig_c_flags = $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS) $(KBUILD_SUBDIR_CCFLAGS) \104orig_c_flags = $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS) $(KBUILD_SUBDIR_CCFLAGS) \
105 $(ccflags-y) $(CFLAGS_$(basetarget).o)105 $(ccflags-y) $(CFLAGS_$(basetarget).o)
@@ -162,7 +162,7 @@ endif · 56 unmodified lines
162 162
163c_flags = -Wp,-MD,$(depfile) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) \163c_flags = -Wp,-MD,$(depfile) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) \
164 $(__c_flags) $(modkern_cflags) \164 $(__c_flags) $(modkern_cflags) \
165 -D"KBUILD_STR(s)=\#s" $(basename_flags) $(modname_flags)165 $(basename_flags) $(modname_flags)
166 166
167a_flags = -Wp,-MD,$(depfile) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) \167a_flags = -Wp,-MD,$(depfile) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) \
168 $(__a_flags) $(modkern_aflags)168 $(__a_flags) $(modkern_aflags)