History

Revert "pinctrl: generic: Add bi-directional and output-enable"

This reverts commit 8c58f1a7a4b6d1d723bf25fef9d842d5a11200d0. It turns out that applying these generic properties was premature: the properties used in the driver using this are of unclear electrical nature and the subject need to be discussed.

Linus Walleij committed 9 years ago

Commit b4d2ea21 parent a9de0803 files · +0 −8Browse files

Unified · Split

3 files
  1. Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt +0 −2
  2. drivers/pinctrl/pinconf-generic.c +0 −3
  3. include/linux/pinctrl/pinconf-generic.h +0 −3
Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt+0−2
@@ -247,7 +247,6 @@ bias-bus-hold - latch weakly · 246 unmodified lines
247247 bias-pull-up - pull up the pin
248248 bias-pull-down - pull down the pin
249249 bias-pull-pin-default - use pin-default pull state
250−bi-directional - pin supports simultaneous input/output operations
251250 drive-push-pull - drive actively high and low
252251 drive-open-drain - drive with open drain
253252 drive-open-source - drive with open source
@@ -260,7 +259,6 @@ input-debounce - debounce mode with debound time X · 6 unmodified lines
260259 power-source - select between different power supplies
261260 low-power-enable - enable low power mode
262261 low-power-disable - disable low power mode
263−output-enable - enable output on pin regardless of output value
264262 output-low - set the pin to output mode with low level
265263 output-high - set the pin to output mode with high level
266264 slew-rate - set the slew rate
drivers/pinctrl/pinconf-generic.c+0−3
@@ -35,7 +35,6 @@ static const struct pin_config_item conf_items[] = { · 34 unmodified lines
3535 PCONFDUMP(PIN_CONFIG_BIAS_PULL_PIN_DEFAULT,
3636 "input bias pull to pin specific state", NULL, false),
3737 PCONFDUMP(PIN_CONFIG_BIAS_PULL_UP, "input bias pull up", NULL, false),
38− PCONFDUMP(PIN_CONFIG_BIDIRECTIONAL, "bi-directional pin operations", NULL, false),
3938 PCONFDUMP(PIN_CONFIG_DRIVE_OPEN_DRAIN, "output drive open drain", NULL, false),
4039 PCONFDUMP(PIN_CONFIG_DRIVE_OPEN_SOURCE, "output drive open source", NULL, false),
4140 PCONFDUMP(PIN_CONFIG_DRIVE_PUSH_PULL, "output drive push pull", NULL, false),
@@ -161,7 +160,6 @@ static const struct pinconf_generic_params dt_params[] = { · 119 unmodified lines
161160 { "bias-pull-up", PIN_CONFIG_BIAS_PULL_UP, 1 },
162161 { "bias-pull-pin-default", PIN_CONFIG_BIAS_PULL_PIN_DEFAULT, 1 },
163162 { "bias-pull-down", PIN_CONFIG_BIAS_PULL_DOWN, 1 },
164− { "bi-directional", PIN_CONFIG_BIDIRECTIONAL, 1 },
165163 { "drive-open-drain", PIN_CONFIG_DRIVE_OPEN_DRAIN, 0 },
166164 { "drive-open-source", PIN_CONFIG_DRIVE_OPEN_SOURCE, 0 },
167165 { "drive-push-pull", PIN_CONFIG_DRIVE_PUSH_PULL, 0 },
@@ -174,7 +172,6 @@ static const struct pinconf_generic_params dt_params[] = { · 6 unmodified lines
174172 { "input-schmitt-enable", PIN_CONFIG_INPUT_SCHMITT_ENABLE, 1 },
175173 { "low-power-disable", PIN_CONFIG_LOW_POWER_MODE, 0 },
176174 { "low-power-enable", PIN_CONFIG_LOW_POWER_MODE, 1 },
177− { "output-enable", PIN_CONFIG_OUTPUT, 1, },
178175 { "output-high", PIN_CONFIG_OUTPUT, 1, },
179176 { "output-low", PIN_CONFIG_OUTPUT, 0, },
180177 { "power-source", PIN_CONFIG_POWER_SOURCE, 0 },
include/linux/pinctrl/pinconf-generic.h+0−3
@@ -42,8 +42,6 @@ · 41 unmodified lines
4242 * @PIN_CONFIG_BIAS_PULL_UP: the pin will be pulled up (usually with high
4343 * impedance to VDD). If the argument is != 0 pull-up is enabled,
4444 * if it is 0, pull-up is total, i.e. the pin is connected to VDD.
45− * @PIN_CONFIG_BIDIRECTIONAL: the pin will be configured to allow simultaneous
46− * input and output operations.
4745 * @PIN_CONFIG_DRIVE_OPEN_DRAIN: the pin will be driven with open drain (open
4846 * collector) which means it is usually wired with other output ports
4947 * which are then pulled up with an external resistor. Setting this
@@ -98,7 +96,6 @@ enum pin_config_param { · 48 unmodified lines
9896 PIN_CONFIG_BIAS_PULL_DOWN,
9997 PIN_CONFIG_BIAS_PULL_PIN_DEFAULT,
10098 PIN_CONFIG_BIAS_PULL_UP,
101− PIN_CONFIG_BIDIRECTIONAL,
10299 PIN_CONFIG_DRIVE_OPEN_DRAIN,
103100 PIN_CONFIG_DRIVE_OPEN_SOURCE,
104101 PIN_CONFIG_DRIVE_PUSH_PULL,