The 'old_size' is a __le64 type since birth, not sure why the kclient incorrectly switched it to __le32. This change is okay won't break anything because union will always allocate more memory than the 'open' member needed. Rename 'file_replication' to 'pool' as ceph did. Though this 'open' struct may never be used in kclient in future, it's confusing when going through the ceph code.
Showing the changes to include/linux/ceph (1 of 1 file). Show all
Unified · Split
| @@ -433,9 +433,9 @@ union ceph_mds_request_args { · 432 unmodified lines | |||
| 433 | __le32 stripe_unit; /* layout for newly created file */ | 433 | __le32 stripe_unit; /* layout for newly created file */ |
| 434 | __le32 stripe_count; /* ... */ | 434 | __le32 stripe_count; /* ... */ |
| 435 | __le32 object_size; | 435 | __le32 object_size; |
| 436 | __le32 file_replication; | 436 | __le32 pool; |
| 437 | __le32 mask; /* CEPH_CAP_* */ | 437 | __le32 mask; /* CEPH_CAP_* */ |
| 438 | __le32 old_size; | 438 | __le64 old_size; |
| 439 | } __attribute__ ((packed)) open; | 439 | } __attribute__ ((packed)) open; |
| 440 | struct { | 440 | struct { |
| 441 | __le32 flags; | 441 | __le32 flags; |