History

block: allow use of per-cpu bio alloc cache by block drivers

Refine per-cpu bio alloc cache interfaces so that DM and other block drivers can properly create and use the cache: DM uses bioset_init_from_src() to do its final bioset initialization, so must update bioset_init_from_src() to set BIOSET_PERCPU_CACHE if %src bioset has a cache. Also move bio_clear_polled() to include/linux/bio.h to allow users outside of block core.

Mike Snitzer committed 4 years ago

Commit b53f3dc1 parent 0df71653 files · +8 −6Browse files

Unified · Split

3 files
  1. block/bio.c +2 −0
  2. block/blk.h +0 −6
  3. include/linux/bio.h +6 −0
block/bio.c+2−0
@@ -1767,6 +1767,8 @@ int bioset_init_from_src(struct bio_set *bs, struct bio_set *src) · 1766 unmodified lines
17671767 flags |= BIOSET_NEED_BVECS;
17681768 if (src->rescue_workqueue)
17691769 flags |= BIOSET_NEED_RESCUER;
1770+ if (src->cache)
1771+ flags |= BIOSET_PERCPU_CACHE;
17701772
17711773 return bioset_init(bs, src->bio_pool.min_nr, src->front_pad, flags);
17721774 }
block/blk.h+0−6
@@ -450,12 +450,6 @@ extern struct device_attribute dev_attr_events; · 449 unmodified lines
450450 extern struct device_attribute dev_attr_events_async;
451451 extern struct device_attribute dev_attr_events_poll_msecs;
452452
453−static inline void bio_clear_polled(struct bio *bio)
454−{
455− /* can't support alloc cache if we turn off polling */
456− bio->bi_opf &= ~(REQ_POLLED | REQ_ALLOC_CACHE);
457−}
458−
459453 long blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg);
460454 long compat_blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg);
461455
include/linux/bio.h+6−0
@@ -780,6 +780,12 @@ static inline void bio_set_polled(struct bio *bio, struct kiocb *kiocb) · 779 unmodified lines
780780 bio->bi_opf |= REQ_NOWAIT;
781781 }
782782
783+static inline void bio_clear_polled(struct bio *bio)
784+{
785+ /* can't support alloc cache if we turn off polling */
786+ bio->bi_opf &= ~(REQ_POLLED | REQ_ALLOC_CACHE);
787+}
788+
783789 struct bio *blk_next_bio(struct bio *bio, struct block_device *bdev,
784790 unsigned int nr_pages, unsigned int opf, gfp_t gfp);
785791

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t