A "short" ARS (address range scrub) instructs the platform firmware to return known errors. In contrast, a "long" ARS instructs platform firmware to arrange every data address on the DIMM to be read / checked for poisoned data. The conversion of the flags in commit d3abaf43bab8 "acpi, nfit: Fix Address Range Scrub completion tracking", changed the meaning of passing '0' to acpi_nfit_ars_rescan(). Previously '0' meant "not short", now '0' is ARS_REQ_SHORT. Pass ARS_REQ_LONG to restore the expected scrub-type behavior of user-initiated ARS sessions.
Unified · Split
| @@ -1308,7 +1308,7 @@ static ssize_t scrub_store(struct device *dev, · 1307 unmodified lines | |||
| 1308 | if (nd_desc) { | 1308 | if (nd_desc) { |
| 1309 | struct acpi_nfit_desc *acpi_desc = to_acpi_desc(nd_desc); | 1309 | struct acpi_nfit_desc *acpi_desc = to_acpi_desc(nd_desc); |
| 1310 | 1310 | ||
| 1311 | rc = acpi_nfit_ars_rescan(acpi_desc, 0); | 1311 | rc = acpi_nfit_ars_rescan(acpi_desc, ARS_REQ_LONG); |
| 1312 | } | 1312 | } |
| 1313 | device_unlock(dev); | 1313 | device_unlock(dev); |
| 1314 | if (rc) | 1314 | if (rc) |