History

mach-integrator: fix VGA base regression

The changes introduced in commit cc22b4c18540e5e8bf55c7d124044f9317527d3c "ARM: set vga memory base at run-time" Makes the Integrator/AP freeze completely. I appears that this is due to the VGA base address being assigned at PCI init time, while this base is needed earlier than that. Moving the initialization of the base address to the .map_io function solves this problem.

Linus Walleij committed 15 years ago

Commit b71d8421 parent a0638eb2 files · +2 −2Browse files

Unified · Split

2 files
  1. arch/arm/mach-integrator/integrator_ap.c +2 −0
  2. arch/arm/mach-integrator/pci_v3.c +0 −2
arch/arm/mach-integrator/integrator_ap.c+2−0
@@ -32,6 +32,7 @@ · 31 unmodified lines
3232 #include <linux/interrupt.h>
3333 #include <linux/io.h>
3434 #include <linux/mtd/physmap.h>
35+#include <video/vga.h>
3536
3637 #include <mach/hardware.h>
3738 #include <mach/platform.h>
@@ -154,6 +155,7 @@ static struct map_desc ap_io_desc[] __initdata = { · 116 unmodified lines
154155 static void __init ap_map_io(void)
155156 {
156157 iotable_init(ap_io_desc, ARRAY_SIZE(ap_io_desc));
158+ vga_base = PCI_MEMORY_VADDR;
157159 }
158160
159161 #define INTEGRATOR_SC_VALID_INT 0x003fffff
arch/arm/mach-integrator/pci_v3.c+0−2
@@ -27,7 +27,6 @@ · 26 unmodified lines
2727 #include <linux/spinlock.h>
2828 #include <linux/init.h>
2929 #include <linux/io.h>
30−#include <video/vga.h>
3130
3231 #include <mach/hardware.h>
3332 #include <mach/platform.h>
@@ -505,7 +504,6 @@ void __init pci_v3_preinit(void) · 471 unmodified lines
505504
506505 pcibios_min_io = 0x6000;
507506 pcibios_min_mem = 0x00100000;
508− vga_base = PCI_MEMORY_VADDR;
509507
510508 /*
511509 * Hook in our fault handler for PCI errors